Bug 147373 - DFG::ArgumentsEliminationPhase has a redundant check for inserting CheckInBounds when converting GetByVal to GetStack in the inline non-varargs case
Summary: DFG::ArgumentsEliminationPhase has a redundant check for inserting CheckInBou...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-28 13:57 PDT by Filip Pizlo
Modified: 2015-07-28 14:24 PDT (History)
12 users (show)

See Also:

Attachments
the patch (3.17 KB, patch)
2015-07-28 14:12 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (3.39 KB, patch)
2015-07-28 14:14 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (3.45 KB, patch)
2015-07-28 14:15 PDT, Filip Pizlo 		mark.lam: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-07-28 13:57:35 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2015-07-28 14:12:29 PDT 
Created attachment 257681 [details]
the patch
Comment 2 Filip Pizlo 2015-07-28 14:14:27 PDT 
Created attachment 257682 [details]
the patch
Comment 3 Filip Pizlo 2015-07-28 14:15:18 PDT 
Created attachment 257683 [details]
the patch
Comment 4 Mark Lam 2015-07-28 14:23:22 PDT 
Comment on attachment 257683 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257683&action=review

r=me

> Source/JavaScriptCore/ChangeLog:14
> +        1) Impossible to convert because. This can happen if the GetByVal is out-of-bounds of the

Remove the stray "because".
Comment 5 Filip Pizlo 2015-07-28 14:24:46 PDT 
Landed in http://trac.webkit.org/changeset/187513