RESOLVED FIXED 147373
DFG::ArgumentsEliminationPhase has a redundant check for inserting CheckInBounds when converting GetByVal to GetStack in the inline non-varargs case 
https://bugs.webkit.org/show_bug.cgi?id=147373
Summary DFG::ArgumentsEliminationPhase has a redundant check for inserting CheckInBou...
Filip Pizlo
Reported 2015-07-28 13:57:35 PDT
Patch forthcoming.
Attachments
the patch (3.17 KB, patch)
2015-07-28 14:12 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (3.39 KB, patch)
2015-07-28 14:14 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (3.45 KB, patch)
2015-07-28 14:15 PDT, Filip Pizlo 		mark.lam: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-07-28 14:12:29 PDT
Created attachment 257681 [details] the patch
Filip Pizlo
Comment 2 2015-07-28 14:14:27 PDT
Created attachment 257682 [details] the patch
Filip Pizlo
Comment 3 2015-07-28 14:15:18 PDT
Created attachment 257683 [details] the patch
Mark Lam
Comment 4 2015-07-28 14:23:22 PDT
Comment on attachment 257683 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=257683&action=review r=me > Source/JavaScriptCore/ChangeLog:14 > + 1) Impossible to convert because. This can happen if the GetByVal is out-of-bounds of the Remove the stray "because".
Filip Pizlo
Comment 5 2015-07-28 14:24:46 PDT
Landed in http://trac.webkit.org/changeset/187513
Note You need to log in before you can comment on or make changes to this bug.