Bug 147371 - DFG::PutStackSinkingPhase should be more aggressive about its "no GetStack until put" rule
Summary: DFG::PutStackSinkingPhase should be more aggressive about its "no GetStack un...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-28 13:38 PDT by Filip Pizlo
Modified: 2015-07-28 13:51 PDT (History)
12 users (show)

See Also:

Attachments
the patch (4.00 KB, patch)
2015-07-28 13:40 PDT, Filip Pizlo 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-07-28 13:38:40 PDT 
PutStackSinkingPhase assumes that you won't issue a GetStack until you've already done a PutStack or some other store to that stack location (for example via ForwardVarargs or because it's an argument).  One of the reasons why it currently doesn't enforce this because it's sloppy about using ConflictingFlush, the current signal that the stack slot is dirty.  We should fix both issues.
Comment 1 Filip Pizlo 2015-07-28 13:40:33 PDT 
Created attachment 257676 [details]
the patch
Comment 2 Mark Lam 2015-07-28 13:48:19 PDT 
Comment on attachment 257676 [details]
the patch

r=me
Comment 3 Filip Pizlo 2015-07-28 13:51:59 PDT 
Landed in http://trac.webkit.org/changeset/187510