RESOLVED FIXED 147371
DFG::PutStackSinkingPhase should be more aggressive about its "no GetStack until put" rule 
https://bugs.webkit.org/show_bug.cgi?id=147371
Summary DFG::PutStackSinkingPhase should be more aggressive about its "no GetStack un...
Filip Pizlo
Reported 2015-07-28 13:38:40 PDT
PutStackSinkingPhase assumes that you won't issue a GetStack until you've already done a PutStack or some other store to that stack location (for example via ForwardVarargs or because it's an argument). One of the reasons why it currently doesn't enforce this because it's sloppy about using ConflictingFlush, the current signal that the stack slot is dirty. We should fix both issues.
Attachments
the patch (4.00 KB, patch)
2015-07-28 13:40 PDT, Filip Pizlo 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-07-28 13:40:33 PDT
Created attachment 257676 [details] the patch
Mark Lam
Comment 2 2015-07-28 13:48:19 PDT
Comment on attachment 257676 [details] the patch r=me
Filip Pizlo
Comment 3 2015-07-28 13:51:59 PDT
Landed in http://trac.webkit.org/changeset/187510
Note You need to log in before you can comment on or make changes to this bug.