Bug 147367 – [iOS] Pressing 'done' in fullscreen video sometimes does nothing; stuck in fullscreen

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

[iOS] Pressing 'done' in fullscreen video sometimes does nothing; stuck in fullscreen

[Jer Noble]

Created attachment 257674 [details]
Patch

[Eric Carlson]

Comment on attachment 257674 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257674&action=review

> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.h:151
> +    WebCore::Timer m_watchdogTimer;

Nit: Isn't RunLoop::Timer<> the new hotness?

> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:1389
> +    if (!m_watchdogTimer.isActive())

You should probably remove this check so you reset the watchdog in the (unlikely?) event that this is called recursively.

[Jer Noble]

(In reply to comment #2)
> Comment on attachment 257674 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=257674&action=review
> 
> > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.h:151
> > +    WebCore::Timer m_watchdogTimer;
> 
> Nit: Isn't RunLoop::Timer<> the new hotness?

That takes a RunLoop& parameter, which we don't have access to.

> > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:1389
> > +    if (!m_watchdogTimer.isActive())
> 
> You should probably remove this check so you reset the watchdog in the
> (unlikely?) event that this is called recursively.

I want to avoid a situation where AVKit asks us to exit repeatedly, but we never do because the request keeps resetting the timer.

[Jer Noble]

Created attachment 257684 [details]
Patch for landing

[Jer Noble]

<rdar://problem/22001027>

[WebKit Commit Bot]

Comment on attachment 257684 [details]
Patch for landing

Clearing flags on attachment: 257684

Committed r187617: <http://trac.webkit.org/changeset/187617>

[Radar WebKit Bug Importer]

<rdar://problem/23730199>