Bug 147367 - [iOS] Pressing 'done' in fullscreen video sometimes does nothing; stuck in fullscreen
Summary: [iOS] Pressing 'done' in fullscreen video sometimes does nothing; stuck in fu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-07-28 13:27 PDT by Jer Noble
Modified: 2015-12-02 13:25 PST (History)
2 users (show)

See Also:


Attachments
Patch (4.61 KB, patch)
2015-07-28 13:32 PDT, Jer Noble
eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing (5.10 KB, patch)
2015-07-28 14:17 PDT, Jer Noble
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2015-07-28 13:27:06 PDT
[iOS] Pressing 'done' in fullscreen video sometimes does nothing; stuck in fullscreen
Comment 1 Jer Noble 2015-07-28 13:32:08 PDT
Created attachment 257674 [details]
Patch
Comment 2 Eric Carlson 2015-07-28 13:39:20 PDT
Comment on attachment 257674 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257674&action=review

> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.h:151
> +    WebCore::Timer m_watchdogTimer;

Nit: Isn't RunLoop::Timer<> the new hotness?

> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:1389
> +    if (!m_watchdogTimer.isActive())

You should probably remove this check so you reset the watchdog in the (unlikely?) event that this is called recursively.
Comment 3 Jer Noble 2015-07-28 13:45:09 PDT
(In reply to comment #2)
> Comment on attachment 257674 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=257674&action=review
> 
> > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.h:151
> > +    WebCore::Timer m_watchdogTimer;
> 
> Nit: Isn't RunLoop::Timer<> the new hotness?

That takes a RunLoop& parameter, which we don't have access to.

> > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:1389
> > +    if (!m_watchdogTimer.isActive())
> 
> You should probably remove this check so you reset the watchdog in the
> (unlikely?) event that this is called recursively.

I want to avoid a situation where AVKit asks us to exit repeatedly, but we never do because the request keeps resetting the timer.
Comment 4 Jer Noble 2015-07-28 14:17:46 PDT
Created attachment 257684 [details]
Patch for landing
Comment 5 Jer Noble 2015-07-30 15:19:13 PDT
<rdar://problem/22001027>
Comment 6 WebKit Commit Bot 2015-07-30 16:17:52 PDT
Comment on attachment 257684 [details]
Patch for landing

Clearing flags on attachment: 257684

Committed r187617: <http://trac.webkit.org/changeset/187617>
Comment 7 Radar WebKit Bug Importer 2015-12-02 13:25:17 PST
<rdar://problem/23730199>