Bug 147364 - Web Inspector: Convert NavigationItem subclasses to ES6
Summary: Web Inspector: Convert NavigationItem subclasses to ES6
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brian Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-07-28 10:38 PDT by Brian Burg
Modified: 2015-07-28 14:54 PDT (History)
7 users (show)

See Also:

Attachments
Patch (37.52 KB, patch)
2015-07-28 10:43 PDT, Brian Burg 		timothy: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2015-07-28 10:38:57 PDT 
.
Comment 1 Radar WebKit Bug Importer 2015-07-28 10:39:14 PDT 
<rdar://problem/22033042>
Comment 2 Brian Burg 2015-07-28 10:43:17 PDT 
Created attachment 257658 [details]
Patch
Comment 3 Timothy Hatcher 2015-07-28 12:19:14 PDT 
Comment on attachment 257658 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257658&action=review

> Source/WebInspectorUI/UserInterface/Views/NavigationItem.js:93
>          var classNames = [WebInspector.NavigationItem.StyleClassName];

Could inline this and remove the global.

> Source/WebInspectorUI/UserInterface/Views/NavigationItem.js:103
> +WebInspector.NavigationItem.HiddenStyleClassName = "hidden";

Could be inlined in get hidden(), and use classList.toggle("hidden", flag) there.
Comment 4 Brian Burg 2015-07-28 14:52:54 PDT 
Comment on attachment 257658 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257658&action=review

>> Source/WebInspectorUI/UserInterface/Views/NavigationItem.js:103
>> +WebInspector.NavigationItem.HiddenStyleClassName = "hidden";
> 
> Could be inlined in get hidden(), and use classList.toggle("hidden", flag) there.

OK, fixed this.
Comment 5 Brian Burg 2015-07-28 14:54:41 PDT 
Committed r187519: <http://trac.webkit.org/changeset/187519>