Bug 147363 - Simplify call linking
Summary: Simplify call linking
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basile Clement
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-28 10:18 PDT by Basile Clement
Modified: 2015-07-28 13:13 PDT (History)
7 users (show)

See Also:

Attachments
Patch (46.53 KB, patch)
2015-07-28 11:05 PDT, Basile Clement 		fpizlo: review+
Details | Formatted Diff | Diff
Benchmark results (Conf #2 is the patch) (53.37 KB, text/plain)
2015-07-28 11:07 PDT, Basile Clement 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Basile Clement 2015-07-28 10:18:55 PDT 
Currently, we are passing both a CallLinkInfo and a (CodeSpecializationKind, RegisterPreservationMode) pair to the different call linking slow paths. However, the CallLinkInfo has the CodeSpecializationKind and RegisterPreservationMode already, leading to useless boilerplate.
Comment 1 Basile Clement 2015-07-28 11:05:12 PDT 
Created attachment 257660 [details]
Patch
Comment 2 Basile Clement 2015-07-28 11:07:43 PDT 
Created attachment 257662 [details]
Benchmark results (Conf #2 is the patch)
Comment 3 Filip Pizlo 2015-07-28 11:08:04 PDT 
Comment on attachment 257660 [details]
Patch

Looks great!
Comment 4 Basile Clement 2015-07-28 13:13:59 PDT 
Committed r187505: <http://trac.webkit.org/changeset/187505>