WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
147360
Web Inspector: Decrease the padding of each rule in the Rules sidebar to allow more content to show
https://bugs.webkit.org/show_bug.cgi?id=147360
Summary
Web Inspector: Decrease the padding of each rule in the Rules sidebar to allo...
Devin Rousso
Reported
2015-07-28 09:56:56 PDT
Based on suggestions from
https://bugs.webkit.org/show_bug.cgi?id=145982
Attachments
Patch
(13.07 KB, patch)
2015-07-28 09:58 PDT
,
Devin Rousso
timothy
: review+
commit-queue
: commit-queue-
Details
Formatted Diff
Diff
After Patch is applied
(137.80 KB, image/png)
2015-07-28 10:16 PDT
,
Devin Rousso
no flags
Details
Current Functionality
(121.49 KB, image/png)
2015-07-28 10:16 PDT
,
Devin Rousso
no flags
Details
[Image] Before/after side-by-side
(208.14 KB, image/png)
2015-07-28 10:49 PDT
,
Matt Baker
no flags
Details
Patch
(13.30 KB, patch)
2015-08-07 21:49 PDT
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Devin Rousso
Comment 1
2015-07-28 09:58:48 PDT
Created
attachment 257651
[details]
Patch
Radar WebKit Bug Importer
Comment 2
2015-07-28 09:59:00 PDT
<
rdar://problem/22032039
>
Matt Baker
Comment 3
2015-07-28 10:12:41 PDT
A before/after screenshot would be great.
Devin Rousso
Comment 4
2015-07-28 10:15:54 PDT
(In reply to
comment #3
)
> A before/after screenshot would be great.
Whoops. Sorry, I completely forgot to upload them. I'll do that now.
Devin Rousso
Comment 5
2015-07-28 10:16:32 PDT
Created
attachment 257652
[details]
After Patch is applied
Devin Rousso
Comment 6
2015-07-28 10:16:49 PDT
Created
attachment 257653
[details]
Current Functionality
Matt Baker
Comment 7
2015-07-28 10:49:39 PDT
Created
attachment 257659
[details]
[Image] Before/after side-by-side
Timothy Hatcher
Comment 8
2015-07-28 12:26:09 PDT
Comment on
attachment 257651
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=257651&action=review
> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.css:-56 > -.style-declaration-section.last-in-group + .style-declaration-section { > - margin-top: 15px; > - > - border-top-color: hsla(0, 0%, 0%, 0.3); > -}
Why is this no longer needed?
> Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.css:94 > + content: url(../Images/Plus.svg);
You should add opacity: 0.7;
Devin Rousso
Comment 9
2015-07-28 13:05:18 PDT
Comment on
attachment 257651
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=257651&action=review
>> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.css:-56 >> -} > > Why is this no longer needed?
That was what was used as spacing between rules without media queries before "Media: all" was added. Now that "Media: all" is put before any rule that doesn't have a media query, this rule will never match as there will be a label between .last-in-group and the next .style-declaratio-section.
Timothy Hatcher
Comment 10
2015-08-07 20:56:53 PDT
You can set commit-queue + on reviewed patches since you are a commiter. You just can't set review + yet.
WebKit Commit Bot
Comment 11
2015-08-07 20:57:31 PDT
Comment on
attachment 257651
[details]
Patch Rejecting
attachment 257651
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 257651, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: torUI/UserInterface/Views/RulesStyleDetailsPanel.js Hunk #1 succeeded at 178 (offset 18 lines). Hunk #2 succeeded at 294 (offset 18 lines). Hunk #3 succeeded at 395 with fuzz 1 (offset 23 lines). Hunk #4 FAILED at 449. 1 out of 4 hunks FAILED -- saving rejects to file Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.js.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output:
http://webkit-queues.webkit.org/results/29611
Devin Rousso
Comment 12
2015-08-07 20:58:17 PDT
(In reply to
comment #10
)
> You can set commit-queue + on reviewed patches since you are a commiter. You > just can't set review + yet.
Oh haha sorry I didn't know that. Thanks for the info!
Timothy Hatcher
Comment 13
2015-08-07 20:59:19 PDT
In this case, add me to the ChangeLog as the reviewer after you rebase. Then upload the patch and cq+ it and leave r blank.
Devin Rousso
Comment 14
2015-08-07 21:49:09 PDT
Created
attachment 258559
[details]
Patch
WebKit Commit Bot
Comment 15
2015-08-07 22:39:57 PDT
Comment on
attachment 258559
[details]
Patch Clearing flags on attachment: 258559 Committed
r188188
: <
http://trac.webkit.org/changeset/188188
>
WebKit Commit Bot
Comment 16
2015-08-07 22:40:01 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug