Bug 147360 – Web Inspector: Decrease the padding of each rule in the Rules sidebar to allow more content to show

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

Based on suggestions from https://bugs.webkit.org/show_bug.cgi?id=145982

[Devin Rousso]

Created attachment 257651 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/22032039>

[Matt Baker]

A before/after screenshot would be great.

[Devin Rousso]

(In reply to comment #3)
> A before/after screenshot would be great.

Whoops.  Sorry, I completely forgot to upload them.  I'll do that now.

[Devin Rousso]

Created attachment 257652 [details]
After Patch is applied

[Devin Rousso]

Created attachment 257653 [details]
Current Functionality

[Matt Baker]

Created attachment 257659 [details]
[Image] Before/after side-by-side

[Timothy Hatcher]

Comment on attachment 257651 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257651&action=review

> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.css:-56
> -.style-declaration-section.last-in-group + .style-declaration-section {
> -    margin-top: 15px;
> -
> -    border-top-color: hsla(0, 0%, 0%, 0.3);
> -}

Why is this no longer needed?

> Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.css:94
> +    content: url(../Images/Plus.svg);

You should add opacity: 0.7;

[Devin Rousso]

Comment on attachment 257651 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257651&action=review

>> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.css:-56
>> -}
> 
> Why is this no longer needed?

That was what was used as spacing between rules without media queries before "Media: all" was added.  Now that "Media: all" is put before any rule that doesn't have a media query, this rule will never match as there will be a label between .last-in-group and the next .style-declaratio-section.

[Timothy Hatcher]

You can set commit-queue + on reviewed patches since you are a commiter. You just can't set review + yet.

[WebKit Commit Bot]

Comment on attachment 257651 [details]
Patch

Rejecting attachment 257651 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 257651, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
torUI/UserInterface/Views/RulesStyleDetailsPanel.js
Hunk #1 succeeded at 178 (offset 18 lines).
Hunk #2 succeeded at 294 (offset 18 lines).
Hunk #3 succeeded at 395 with fuzz 1 (offset 23 lines).
Hunk #4 FAILED at 449.
1 out of 4 hunks FAILED -- saving rejects to file Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.js.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/29611

[Devin Rousso]

(In reply to comment #10)
> You can set commit-queue + on reviewed patches since you are a commiter. You
> just can't set review + yet.

Oh haha sorry I didn't know that.  Thanks for the info!

[Timothy Hatcher]

In this case, add me to the ChangeLog as the reviewer after you rebase. Then upload the patch and cq+ it and leave r blank.

[Devin Rousso]

Created attachment 258559 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 258559 [details]
Patch

Clearing flags on attachment: 258559

Committed r188188: <http://trac.webkit.org/changeset/188188>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.