Bug 147359 - webkitbot and WKR unnecessarily rely on webkit-queues.appspot.com
Summary: webkitbot and WKR unnecessarily rely on webkit-queues.appspot.com
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-28 09:51 PDT by Alexey Proskuryakov
Modified: 2015-07-28 12:39 PDT (History)
4 users (show)

See Also:


Attachments
proposed fix (1.98 KB, patch)
2015-07-28 09:55 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-07-28 09:51:38 PDT
appspot is currently down, and so are webkitbot and WKR.

It doesn't appear that their dependency on appspot is needed though - we do get log entries in webkit-queues.appspot.com datastore when the bots start, but these seem pretty useless.
Comment 1 Alexey Proskuryakov 2015-07-28 09:55:17 PDT
Created attachment 257650 [details]
proposed fix

    def begin_work_queue(self):
        _log.info("CAUTION: %s will discard all local changes in \"%s\"" % (self.name, self._tool.scm().checkout_root))

# This is obviously not enabled on bots. Not sure how much we care about the case when someone runs WKR or webkitbot locally.
        if self._options.confirm:
            response = self._tool.user.prompt("Are you sure?  Type \"yes\" to continue: ")
            if (response != "yes"):
                _log.error("User declined.")
                sys.exit(1)
        _log.info("Running WebKit %s." % self.name)
# This raises an exception after a long timeout, and prevents the queue from running.
        self._tool.status_server.update_status(self.name, "Starting Queue")
Comment 2 WebKit Commit Bot 2015-07-28 12:39:40 PDT
Comment on attachment 257650 [details]
proposed fix

Clearing flags on attachment: 257650

Committed r187501: <http://trac.webkit.org/changeset/187501>
Comment 3 WebKit Commit Bot 2015-07-28 12:39:44 PDT
All reviewed patches have been landed.  Closing bug.