Bug 147358 - [GTK] Fix empty space in popup menus when first item is selected
Summary: [GTK] Fix empty space in popup menus when first item is selected
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2015-07-28 05:19 PDT by Carlos Garcia Campos
Modified: 2015-07-28 23:49 PDT (History)
0 users

See Also:

Attachments
Screenshot showing the problem (87.53 KB, image/png)
2015-07-28 05:19 PDT, Carlos Garcia Campos 		no flags Details
Patch (1.99 KB, patch)
2015-07-28 05:26 PDT, Carlos Garcia Campos 		mrobinson: review+
Details | Formatted Diff | Diff
Screenshot with the patch applied (122.39 KB, image/png)
2015-07-28 05:26 PDT, Carlos Garcia Campos 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2015-07-28 05:19:38 PDT 
Created attachment 257642 [details]
Screenshot showing the problem

It happens when one of the first elements are selected, because we try to center the current selection on the combo element. When the menu is large enough to make the element centered we need to leave empty space at the beginning. See the attached screenshot.
Comment 1 Carlos Garcia Campos 2015-07-28 05:26:18 PDT 
Created attachment 257643 [details]
Patch

This fixes the issue.
Comment 2 Carlos Garcia Campos 2015-07-28 05:26:50 PDT 
Created attachment 257644 [details]
Screenshot with the patch applied
Comment 3 Carlos Garcia Campos 2015-07-28 23:49:57 PDT 
Committed r187542: <http://trac.webkit.org/changeset/187542>