Bug 147354 - DFG::safeToExecute() cases for GetByOffset/PutByOffset don't handle clobbered structure abstract values correctly
Summary: DFG::safeToExecute() cases for GetByOffset/PutByOffset don't handle clobbered...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-27 22:31 PDT by Filip Pizlo
Modified: 2015-07-28 09:59 PDT (History)
12 users (show)

See Also:

Attachments
the patch (5.28 KB, patch)
2015-07-27 22:38 PDT, Filip Pizlo 		msaboff: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-07-27 22:31:28 PDT 
This is a benign bug, but worth fixing.
Comment 1 Filip Pizlo 2015-07-27 22:38:43 PDT 
Created attachment 257633 [details]
the patch
Comment 2 Filip Pizlo 2015-07-27 22:47:05 PDT 
Comment on attachment 257633 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257633&action=review

> Source/JavaScriptCore/dfg/DFGStructureAbstractValue.h:129
> +    // neither clear nor top.

Meant to say: "neither top nor clobbered".  Fixed locally.
Comment 3 Michael Saboff 2015-07-28 09:45:00 PDT 
Comment on attachment 257633 [details]
the patch

r=me
Comment 4 Filip Pizlo 2015-07-28 09:59:51 PDT 
Landed in http://trac.webkit.org/changeset/187487