WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
147335
Web Inspector: Include <template> node content in DOM Tree
https://bugs.webkit.org/show_bug.cgi?id=147335
Summary
Web Inspector: Include <template> node content in DOM Tree
Joseph Pecoraro
Reported
2015-07-27 14:57:05 PDT
* SUMMARY Include <template> node content in DOM Tree. * TEST <body> <template> <h1>Header</h1> <p>Paragraph</p> </template> </body> * STEPS TO REPRODUCE 1. Inspect test page => Should be able to expand the <template> element in DOM Tree and see its contents. * NOTES - Backend already sends the frontend "DOMNode.templateContent" information, the frontend does nothing with it.
Attachments
[PATCH] Proposed Fix
(6.96 KB, patch)
2015-07-27 15:03 PDT
,
Joseph Pecoraro
no flags
Details
Formatted Diff
Diff
[PATCH] For Landing
(7.04 KB, patch)
2015-07-28 13:54 PDT
,
Joseph Pecoraro
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2015-07-27 14:57:17 PDT
<
rdar://problem/22018682
>
Joseph Pecoraro
Comment 2
2015-07-27 15:03:10 PDT
Created
attachment 257596
[details]
[PATCH] Proposed Fix Won't apply yet, requires the Pseudo Element patch's refactoring.
Timothy Hatcher
Comment 3
2015-07-27 16:29:29 PDT
Comment on
attachment 257596
[details]
[PATCH] Proposed Fix View in context:
https://bugs.webkit.org/attachment.cgi?id=257596&action=review
> Source/WebInspectorUI/UserInterface/Models/DOMNode.js:269 > + templateContent()
Getter?
Joseph Pecoraro
Comment 4
2015-07-27 17:14:55 PDT
(In reply to
comment #3
)
> Comment on
attachment 257596
[details]
> [PATCH] Proposed Fix > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=257596&action=review
> > > Source/WebInspectorUI/UserInterface/Models/DOMNode.js:269 > > + templateContent() > > Getter?
All of these DOMNode methods are methods and can be getters. I want to refactor the style quite a bit, but for this patch at least I wanted to follow the pattern.
WebKit Commit Bot
Comment 5
2015-07-28 13:38:44 PDT
Comment on
attachment 257596
[details]
[PATCH] Proposed Fix Clearing flags on attachment: 257596 Committed
r187507
: <
http://trac.webkit.org/changeset/187507
>
WebKit Commit Bot
Comment 6
2015-07-28 13:38:47 PDT
All reviewed patches have been landed. Closing bug.
Joseph Pecoraro
Comment 7
2015-07-28 13:54:09 PDT
Created
attachment 257679
[details]
[PATCH] For Landing
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug