Bug 147328 - Web Inspector: Object previews for SVG elements shows SVGAnimatedString instead of text
Summary: Web Inspector: Object previews for SVG elements shows SVGAnimatedString inste...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-07-27 11:30 PDT by Devin Rousso
Modified: 2015-08-10 19:16 PDT (History)
9 users (show)

See Also:

Attachments
Current Functionality (67.20 KB, image/png)
2015-07-27 11:30 PDT, Devin Rousso 		no flags Details
Testpage (366 bytes, text/html)
2015-08-03 09:58 PDT, Devin Rousso 		no flags Details
[PATCH] Proposed Fix (5.42 KB, patch)
2015-08-03 14:58 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2015-07-27 11:30:51 PDT 
Created attachment 257574 [details]
Current Functionality

I would expect that the preview of SVG elements would resolve what the classname is correctly instead of displaying [object SVGAnimatedString].  It seems to me that for the preview there should be some logic to parse the string and display the className if the animVal and baseVal match and what currently shows up otherwise.
Comment 1 Radar WebKit Bug Importer 2015-07-27 11:31:11 PDT 
<rdar://problem/22013846>
Comment 2 Devin Rousso 2015-08-03 09:58:55 PDT 
Created attachment 258070 [details]
Testpage

Once the page is loaded and the inspector is open, click on the page to have the SVG elements logged to the console.  The issue lies within the object preview payload.
Comment 3 Joseph Pecoraro 2015-08-03 14:06:56 PDT 
Yes, the issue here is likely in InjectedScript.prototype._nodePreview in Source/JavaScriptCore/inspector/InjectedScriptSource.js.

I can take a look.
Comment 4 Joseph Pecoraro 2015-08-03 14:58:26 PDT 
Created attachment 258120 [details]
[PATCH] Proposed Fix
Comment 5 WebKit Commit Bot 2015-08-04 15:40:35 PDT 
Comment on attachment 258120 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 258120

Committed r187897: <http://trac.webkit.org/changeset/187897>
Comment 6 WebKit Commit Bot 2015-08-04 15:40:39 PDT 
All reviewed patches have been landed.  Closing bug.