Bug 147327 – Allow lax MIME type parsing for same-origin CSS in quirks mode.

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Chris Dumez]

Allow lax MIME type parsing for same-origin CSS in quirks mode.

Radar: <rdar://problem/22010303>

[Chris Dumez]

Known broken sites:
http://www.physioadvisor.com.au/14838650/wrist-tendonitis-physioadvisor.htm
http://wallpaperscraft.com
http://www.spoj.com/ST2015/

[Chris Dumez]

Created attachment 257600 [details]
Patch

[Chris Dumez]

Created attachment 257609 [details]
Patch

[Chris Dumez]

Created attachment 257614 [details]
Patch

[alan baradlay]

Comment on attachment 257614 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257614&action=review

> Source/WebCore/css/StyleSheetContents.cpp:309
> +                if (isStrictParserMode(m_parserContext.mode))
> +                    page->console().addMessage(MessageSource::Security, MessageLevel::Error, "Did not parse stylesheet at '" + cachedStyleSheet->url().stringCenterEllipsizedToLength() + "' because its MIME type was invalid and we are in strict mode.");
> +                else
> +                    page->console().addMessage(MessageSource::Security, MessageLevel::Error, "Did not parse stylesheet at '" + cachedStyleSheet->url().stringCenterEllipsizedToLength() + "' because its MIME type was invalid and it is cross-origin.");
> +            }

- we were in strict mode?
- and it was cross-origin?

[Chris Dumez]

Created attachment 257654 [details]
Patch

[Chris Dumez]

Comment on attachment 257654 [details]
Patch

Clearing flags on attachment: 257654

Committed r187489: <http://trac.webkit.org/changeset/187489>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 257614 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257614&action=review

> Source/WebCore/css/StyleSheetContents.h:43
>  class StyleRuleBase;
>  class StyleRuleImport;
> +class SecurityOrigin;

Not sorted correctly; Security should come before Style.

[Chris Dumez]

(In reply to comment #9)
> Comment on attachment 257614 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=257614&action=review
> 
> > Source/WebCore/css/StyleSheetContents.h:43
> >  class StyleRuleBase;
> >  class StyleRuleImport;
> > +class SecurityOrigin;
> 
> Not sorted correctly; Security should come before Style.

Follow-up nit fix in <http://trac.webkit.org/changeset/187503>, thanks.

[Chris Dumez]

Follow-up test baseline landed in <http://trac.webkit.org/changeset/187512>.

[Chris Dumez]

Committed r187523: <http://trac.webkit.org/changeset/187523>