Bug 147322 – Media Session: give media elements unique IDs

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Matt Rajca]

Web page/element ID pairs will be used to keep track of the "focused" Content media element in the UI process. To be able to identify media elements, we give them unique IDs.

[Radar WebKit Bug Importer]

<rdar://problem/22011625>

[Matt Rajca]

Created attachment 257565 [details]
Patch

[Eric Carlson]

Comment on attachment 257565 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257565&action=review

As we discussed offline, please file a bug about consolidating this with the MediaPlaybackTargetClient map.

> Source/WebCore/html/HTMLMediaElement.cpp:435
> +    static uint64_t elementID = 0;
> +    m_elementID = ++elementID;

Nit: we usually put something like this in a static function, eg. uint64_t nextPlaybackTargetClientContextId() in Document.cpp.

[Matt Rajca]

(In reply to comment #3)
> Comment on attachment 257565 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=257565&action=review
> 
> As we discussed offline, please file a bug about consolidating this with the
> MediaPlaybackTargetClient map.

Filed: https://bugs.webkit.org/show_bug.cgi?id=147522

> 
> > Source/WebCore/html/HTMLMediaElement.cpp:435
> > +    static uint64_t elementID = 0;
> > +    m_elementID = ++elementID;
> 
> Nit: we usually put something like this in a static function, eg. uint64_t
> nextPlaybackTargetClientContextId() in Document.cpp.

Added.

[Matt Rajca]

Committed r187712: <http://trac.webkit.org/changeset/187712>