Bug 147319 - [GTK] Add API to WebKitWebsiteDataManager to handle session and local storage
Summary: [GTK] Add API to WebKitWebsiteDataManager to handle session and local storage
Status: RESOLVED DUPLICATE of bug 146589
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on: 146589
Blocks:
  Show dependency treegraph
 
Reported: 2015-07-27 04:23 PDT by Carlos Garcia Campos
Modified: 2017-01-21 01:58 PST (History)
0 users

See Also:


Attachments
Patch (42.83 KB, patch)
2015-07-27 04:26 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2015-07-27 04:23:21 PDT
Add API to WebKitWebsiteDataManager to handle session and local storage
Comment 1 Carlos Garcia Campos 2015-07-27 04:26:27 PDT
Created attachment 257557 [details]
Patch
Comment 2 Michael Catanzaro 2015-07-27 17:35:05 PDT
Comment on attachment 257557 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257557&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebsiteDataManager.cpp:824
> +                origins = g_list_prepend(origins, webkitSecurityOriginCreate(origin.get()));

Same question as on your other patch: I guess the same origin is guaranteed to not exist in multiple WebsiteDataRecords returned by this query?

> Source/WebKit2/UIProcess/API/gtk/WebKitWebsiteDataManager.cpp:836
> + * @error: return location for error or %NULL to ignore

Again, same question as on your other patch: the GError is not supposed to have any annotations?
Comment 3 Carlos Garcia Campos 2015-07-28 03:43:41 PDT
(In reply to comment #2)
> Comment on attachment 257557 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=257557&action=review
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebsiteDataManager.cpp:824
> > +                origins = g_list_prepend(origins, webkitSecurityOriginCreate(origin.get()));
> 
> Same question as on your other patch: I guess the same origin is guaranteed
> to not exist in multiple WebsiteDataRecords returned by this query?
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebsiteDataManager.cpp:836
> > + * @error: return location for error or %NULL to ignore
> 
> Again, same question as on your other patch: the GError is not supposed to
> have any annotations?

I think this is automatically handled by g-i, the method is marked as throws="1" in the gir file and the parameter is simply removed.
Comment 4 Carlos Garcia Campos 2017-01-21 01:58:13 PST
Closing this, with the new approach I'm going to use a single patch.

*** This bug has been marked as a duplicate of bug 146589 ***