Bug 147311 – Rename PropertyNameMode::Both to PropertyNameMode::StringsAndSymbols

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Yusuke Suzuki]

It makes the meaning clear in the user side (PropertyNameArray array(exec, PropertyNameMode::StringsAndSymbols).

[Yusuke Suzuki]

Created attachment 257537 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 257537 [details]
Patch

Rejecting attachment 257537 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 257537, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
1 out of 1 hunk FAILED -- saving rejects to file Source/JavaScriptCore/ChangeLog.rej
patching file Source/JavaScriptCore/bytecode/ObjectAllocationProfile.h
patching file Source/JavaScriptCore/runtime/EnumerationMode.h
patching file Source/JavaScriptCore/runtime/ObjectConstructor.cpp
patching file Source/JavaScriptCore/runtime/ReflectObject.cpp

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Sam Weinig']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/4755451950399488

[Yusuke Suzuki]

Oh, let's do a manual land.

[Yusuke Suzuki]

Committed r187440: <http://trac.webkit.org/changeset/187440>

[Geoffrey Garen]

If we ever come up with additional kinds of property names, then we should use ::All instead of ::XAndYAndZ. But I'm happy with ::XAndY for now.