Bug 147304 – Web Inspector: Start using Node.prototype.remove

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

Convert the following code:

    refElem.parendNode.removeChild(refElem)

to

    refElem.remove()


Note that when refElem.parendNode is null, refElem.remove() is no-op, it doesn't throw any errors.

[Radar WebKit Bug Importer]

<rdar://problem/22000479>

[Nikita Vasilyev]

Created attachment 257529 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 257529 [details]
Patch

Clearing flags on attachment: 257529

Committed r187405: <http://trac.webkit.org/changeset/187405>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Joseph Pecoraro]

Comment on attachment 257529 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257529&action=review

> Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js:1269
> -            parentElement.removeChild(self);
> +            self.remove();

Is this valid? Isn't "self" here a WebInspector.TreeElement, not a DOM Element?

[Joseph Pecoraro]

(In reply to comment #5)
> Comment on attachment 257529 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=257529&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js:1269
> > -            parentElement.removeChild(self);
> > +            self.remove();
> 
> Is this valid? Isn't "self" here a WebInspector.TreeElement, not a DOM
> Element?

Yes, although this still works, it works in lucky / poor way.

This is inside of remove(), so it calls remove() again asynchronously, and only stops this loop because eventually the actual RemoveChild DOM event would remove this tree element from the parent. Lets fix this.