Bug 147302 – Web Inspector: Start using Node.prototype.before

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Web Inspector

[Nikita Vasilyev]

https://bugs.webkit.org/show_bug.cgi?id=74648 introduced Node.prototype.append, among a few other DOM methods.

Convert the following code:

    refElem.parendNode.insertBefore(newElem, refElem)

to

    refElem.before(newElem)


However, we can't safely convert all occurrences of "insertBefore" to "before".

    baseElem.insertBefore(newElem, refElem)

refElem could be a null here. refElem.before(newElem) would cause an error.

[Radar WebKit Bug Importer]

<rdar://problem/22000400>

[Nikita Vasilyev]

I have found only one instance that satisfier the following requirement:

elemA.parentElement.insertBefore(highlightNode, elemA);
\                                               /
 \------------------ same elements ------------/


https://github.com/WebKit/webkit/blob/981bae9952b1f312b89d362fd39768c075408669/Source/WebInspectorUI/UserInterface/Base/Main.js#L1990

Probably doesn't worth a patch.