Bug 147298 - Expose TextIndicator-backed snapshot and rect gathering on DOMNode
Summary: Expose TextIndicator-backed snapshot and rect gathering on DOMNode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-25 16:01 PDT by Tim Horton
Modified: 2015-07-25 17:33 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.58 KB, patch)
2015-07-25 16:02 PDT, Tim Horton 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-07-25 16:01:00 PDT 
Expose TextIndicator-backed snapshot and rect gathering on DOMNode
Comment 1 Tim Horton 2015-07-25 16:02:05 PDT 
Created attachment 257520 [details]
Patch
Comment 2 WebKit Commit Bot 2015-07-25 16:04:45 PDT 
Attachment 257520 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/objc/DOM.mm:564:  The parameter name "image" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2015-07-25 16:13:08 PDT 
http://trac.webkit.org/changeset/187391
Comment 4 mitz 2015-07-25 16:19:57 PDT 
Comment on attachment 257520 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257520&action=review

> Source/WebCore/bindings/objc/DOMExtensions.h:113
> +- (void)getPreviewSnapshotImage:(CGImageRef*)cgImage andRects:(NSArray **)rects;

Did you mean to add this to the Mac part of the header? This is a public header on Mac, so declarations here requires availability information and some Apple-internal process.
Comment 5 Tim Horton 2015-07-25 16:30:10 PDT 
http://trac.webkit.org/changeset/187392
Comment 6 Tim Horton 2015-07-25 17:33:30 PDT 
http://trac.webkit.org/changeset/187393