RESOLVED FIXED 147298
Expose TextIndicator-backed snapshot and rect gathering on DOMNode 
https://bugs.webkit.org/show_bug.cgi?id=147298
Summary Expose TextIndicator-backed snapshot and rect gathering on DOMNode
Tim Horton
Reported 2015-07-25 16:01:00 PDT
Expose TextIndicator-backed snapshot and rect gathering on DOMNode
Attachments
Patch (3.58 KB, patch)
2015-07-25 16:02 PDT, Tim Horton 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2015-07-25 16:02:05 PDT
Created attachment 257520 [details] Patch
WebKit Commit Bot
Comment 2 2015-07-25 16:04:45 PDT
Attachment 257520 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/objc/DOM.mm:564: The parameter name "image" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 3 2015-07-25 16:13:08 PDT
http://trac.webkit.org/changeset/187391
mitz
Comment 4 2015-07-25 16:19:57 PDT
Comment on attachment 257520 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257520&action=review > Source/WebCore/bindings/objc/DOMExtensions.h:113 > +- (void)getPreviewSnapshotImage:(CGImageRef*)cgImage andRects:(NSArray **)rects; Did you mean to add this to the Mac part of the header? This is a public header on Mac, so declarations here requires availability information and some Apple-internal process.
Tim Horton
Comment 5 2015-07-25 16:30:10 PDT
http://trac.webkit.org/changeset/187392
Tim Horton
Comment 6 2015-07-25 17:33:30 PDT
http://trac.webkit.org/changeset/187393
Note You need to log in before you can comment on or make changes to this bug.