Bug 147289 - [EFL] Build fix in ProtectionSpaceBase.cpp
Summary: [EFL] Build fix in ProtectionSpaceBase.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jinwoo Song
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-24 20:45 PDT by Jinwoo Song
Modified: 2015-07-24 22:31 PDT (History)
1 user (show)

See Also:


Attachments
Patch (1.27 KB, patch)
2015-07-24 20:47 PDT, Jinwoo Song
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jinwoo Song 2015-07-24 20:45:08 PDT
In EFL port, we have following build break.

../../Source/WebCore/platform/network/ProtectionSpaceBase.cpp: In member function ‘bool WebCore::ProtectionSpaceBase::isPasswordBased() const’:
../../Source/WebCore/platform/network/ProtectionSpaceBase.cpp:118:1: error: control reaches end of non-void function [-Werror=return-type]
 }
 ^
cc1plus: all warnings being treated as errors
ninja: build stopped: subcommand failed.
Comment 1 Jinwoo Song 2015-07-24 20:47:07 PDT
Created attachment 257509 [details]
Patch
Comment 2 Brent Fulgham 2015-07-24 21:41:27 PDT
Comment on attachment 257509 [details]
Patch

r=me.
Comment 3 WebKit Commit Bot 2015-07-24 22:31:15 PDT
Comment on attachment 257509 [details]
Patch

Clearing flags on attachment: 257509

Committed r187382: <http://trac.webkit.org/changeset/187382>
Comment 4 WebKit Commit Bot 2015-07-24 22:31:19 PDT
All reviewed patches have been landed.  Closing bug.