RESOLVED FIXED 147289
[EFL] Build fix in ProtectionSpaceBase.cpp 
https://bugs.webkit.org/show_bug.cgi?id=147289
Summary [EFL] Build fix in ProtectionSpaceBase.cpp
Jinwoo Song
Reported 2015-07-24 20:45:08 PDT
In EFL port, we have following build break. ../../Source/WebCore/platform/network/ProtectionSpaceBase.cpp: In member function ‘bool WebCore::ProtectionSpaceBase::isPasswordBased() const’: ../../Source/WebCore/platform/network/ProtectionSpaceBase.cpp:118:1: error: control reaches end of non-void function [-Werror=return-type] } ^ cc1plus: all warnings being treated as errors ninja: build stopped: subcommand failed.
Attachments
Patch (1.27 KB, patch)
2015-07-24 20:47 PDT, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jinwoo Song
Comment 1 2015-07-24 20:47:07 PDT
Created attachment 257509 [details] Patch
Brent Fulgham
Comment 2 2015-07-24 21:41:27 PDT
Comment on attachment 257509 [details] Patch r=me.
WebKit Commit Bot
Comment 3 2015-07-24 22:31:15 PDT
Comment on attachment 257509 [details] Patch Clearing flags on attachment: 257509 Committed r187382: <http://trac.webkit.org/changeset/187382>
WebKit Commit Bot
Comment 4 2015-07-24 22:31:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.