Let's implement ES6 Reflect APIs.
As the first step, just add the namespace.
Generally, Reflect APIs are easy to implement. One concern is Reflect.construct. It may replace the newTarget.
Created attachment 257502 [details] Patch
Created attachment 257503 [details] Patch
Created attachment 257504 [details] Patch
Since the current Reflect JS builtins are empty, it generates empty C array and it becomes compiling error. So I'll add one easy method.
Created attachment 257508 [details] Patch
Let's implement it as a side project :)
Comment on attachment 257508 [details] Patch Thanks! Reflect is also needed for Reflect.Loader impl in modules.
Comment on attachment 257508 [details] Patch Clearing flags on attachment: 257508 Committed r187401: <http://trac.webkit.org/changeset/187401>
All reviewed patches have been landed. Closing bug.
(In reply to comment #10) > Comment on attachment 257508 [details] > Patch > > Clearing flags on attachment: 257508 > > Committed r187401: <http://trac.webkit.org/changeset/187401> It broke the WinCairo build: C:\Users\Alex\Documents\WinCairoBot\win-cairo-release\build\WebKitBuild\Release\DerivedSources\JavaScriptCore\ReflectObject.lut.h(27): error C2065: 'reflectObjectApply' : undeclared identifier [C:\Users\Alex\Documents\WinCairoBot\win-cairo-release\build\WebKitBuild\Release\Source\JavaScriptCore\JavaScriptCore.vcxproj] C:\Users\Alex\Documents\WinCairoBot\win-cairo-release\build\WebKitBuild\Release\DerivedSources\JavaScriptCore\ReflectObject.lut.h(32): error C2065: 'reflectObjectDeleteProperty' : undeclared identifier [C:\Users\Alex\Documents\WinCairoBot\win-cairo-release\build\WebKitBuild\Release\Source\JavaScriptCore\JavaScriptCore.vcxproj] cc-ing WinCairo maintainers
(In reply to comment #12) > (In reply to comment #10) > > Comment on attachment 257508 [details] > > Patch > > > > Clearing flags on attachment: 257508 > > > > Committed r187401: <http://trac.webkit.org/changeset/187401> > > It broke the WinCairo build: > > C:\Users\Alex\Documents\WinCairoBot\win-cairo- > release\build\WebKitBuild\Release\DerivedSources\JavaScriptCore\ReflectObject > .lut.h(27): error C2065: 'reflectObjectApply' : undeclared identifier > [C:\Users\Alex\Documents\WinCairoBot\win-cairo- > release\build\WebKitBuild\Release\Source\JavaScriptCore\JavaScriptCore. > vcxproj] > C:\Users\Alex\Documents\WinCairoBot\win-cairo- > release\build\WebKitBuild\Release\DerivedSources\JavaScriptCore\ReflectObject > .lut.h(32): error C2065: 'reflectObjectDeleteProperty' : undeclared > identifier > [C:\Users\Alex\Documents\WinCairoBot\win-cairo- > release\build\WebKitBuild\Release\Source\JavaScriptCore\JavaScriptCore. > vcxproj] > > > cc-ing WinCairo maintainers I guess it is caused because DerivedSource JSCBuiltins.* are not updsted. Could you peform the clean build?
(In reply to comment #13) > (In reply to comment #12) > > (In reply to comment #10) > > > Comment on attachment 257508 [details] > > > Patch > > > > > > Clearing flags on attachment: 257508 > > > > > > Committed r187401: <http://trac.webkit.org/changeset/187401> > > > > It broke the WinCairo build: > > > > C:\Users\Alex\Documents\WinCairoBot\win-cairo- > > release\build\WebKitBuild\Release\DerivedSources\JavaScriptCore\ReflectObject > > .lut.h(27): error C2065: 'reflectObjectApply' : undeclared identifier > > [C:\Users\Alex\Documents\WinCairoBot\win-cairo- > > release\build\WebKitBuild\Release\Source\JavaScriptCore\JavaScriptCore. > > vcxproj] > > C:\Users\Alex\Documents\WinCairoBot\win-cairo- > > release\build\WebKitBuild\Release\DerivedSources\JavaScriptCore\ReflectObject > > .lut.h(32): error C2065: 'reflectObjectDeleteProperty' : undeclared > > identifier > > [C:\Users\Alex\Documents\WinCairoBot\win-cairo- > > release\build\WebKitBuild\Release\Source\JavaScriptCore\JavaScriptCore. > > vcxproj] > > > > > > cc-ing WinCairo maintainers > . > I guess it is caused because DerivedSource JSCBuiltins.* are not updsted. > Could you peform the clean build? I'll check this.
I triggered clean build on the WinCairo bot, let's see if it helps: https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/47678
(In reply to comment #15) > I triggered clean build on the WinCairo bot, let's see if it helps: > https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/47678 It didn't help and now the bot is completely broken: -- The C compiler identification is unknown -- The CXX compiler identification is unknown -- Configuring incomplete, errors occurred! See also "C:/Users/Alex/Documents/WinCairoBot/win-cairo-release/build/WebKitBuild/Release/CMakeFiles/CMakeOutput.log". See also "C:/Users/Alex/Documents/WinCairoBot/win-cairo-release/build/WebKitBuild/Release/CMakeFiles/CMakeError.log". CMake Error at CMakeLists.txt:2 (project): No CMAKE_C_COMPILER could be found. Tell CMake where to find the compiler by setting either the environment variable "CC" or the CMake cache entry CMAKE_C_COMPILER to the full path to the compiler, or to the compiler name if it is in the PATH. CMake Error at CMakeLists.txt:2 (project): No CMAKE_CXX_COMPILER could be found. Tell CMake where to find the compiler by setting either the environment variable "CXX" or the CMake cache entry CMAKE_CXX_COMPILER to the full path to the compiler, or to the compiler name if it is in the PATH.
(In reply to comment #16) > It didn't help and now the bot is completely broken: That's because I installed ninja and haven't landed https://bugs.webkit.org/show_bug.cgi?id=147228 yet. I'll uninstall ninja and do another clean build.
WinCairo bot becomes green :D