Bug 147286 - check-webkit-style should ignore template specializations when warning about inappropriate identifier names
Summary: check-webkit-style should ignore template specializations when warning about ...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-24 18:18 PDT by Michael Catanzaro
Modified: 2015-07-24 18:18 PDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2015-07-24 18:18:27 PDT 
In bug #147057:

ERROR: Source/WebCore/platform/graphics/freetype/UniquePtrFreeType.cpp:27:  default_delete::operator is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/graphics/freetype/UniquePtrFreeType.cpp:32:  default_delete::operator is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/graphics/freetype/UniquePtrFreeType.cpp:37:  default_delete::operator is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 3 in 15 files

But these are template specializations of templates that are not declared by WebKit (default_delete is actually in namespace std, but that's irrelevant), so they have to be named that.