NEW 147286
check-webkit-style should ignore template specializations when warning about inappropriate identifier names 
https://bugs.webkit.org/show_bug.cgi?id=147286
Summary check-webkit-style should ignore template specializations when warning about ...
Michael Catanzaro
Reported 2015-07-24 18:18:27 PDT
In bug #147057: ERROR: Source/WebCore/platform/graphics/freetype/UniquePtrFreeType.cpp:27: default_delete::operator is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/freetype/UniquePtrFreeType.cpp:32: default_delete::operator is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/freetype/UniquePtrFreeType.cpp:37: default_delete::operator is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 3 in 15 files But these are template specializations of templates that are not declared by WebKit (default_delete is actually in namespace std, but that's irrelevant), so they have to be named that.
Attachments
Add attachment proposed patch, testcase, etc.
Note You need to log in before you can comment on or make changes to this bug.