RESOLVED FIXED 147278
Bug #147164 "[iOS] Keyboard bold/italic/underline keys don't highlight after being tapped to style a selection" needs a test 
https://bugs.webkit.org/show_bug.cgi?id=147278
Summary Bug #147164 "[iOS] Keyboard bold/italic/underline keys don't highlight after ...
Jon Honeycutt
Reported 2015-07-24 14:57:25 PDT
Bug #147164 should have a test.
Attachments
Patch (8.46 KB, patch)
2015-07-24 15:01 PDT, Jon Honeycutt 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jon Honeycutt
Comment 1 2015-07-24 15:01:58 PDT
Created attachment 257482 [details] Patch
WebKit Commit Bot
Comment 2 2015-07-24 15:04:29 PDT
Attachment 257482 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/mac/WordBoundaryTypingAttributes.mm:54: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/mac/WordBoundaryTypingAttributes.mm:55: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/TestWebKitAPI/Tests/mac/WordBoundaryTypingAttributes.mm:64: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/mac/WordBoundaryTypingAttributes.mm:64: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/TestWebKitAPI/Tests/mac/WordBoundaryTypingAttributes.mm:72: Consider using EXPECT_NE instead of EXPECT_TRUE(a != b) [readability/check] [2] ERROR: Tools/TestWebKitAPI/Tests/mac/WordBoundaryTypingAttributes.mm:72: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 6 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ryosuke Niwa
Comment 3 2015-07-25 00:37:44 PDT
Comment on attachment 257482 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257482&action=review > Tools/TestWebKitAPI/Tests/mac/WordBoundaryTypingAttributes.mm:61 > + selection.removeAllRanges(); \ You can just do getSelection().setBaseAndExtent(node, 7, node, 12) instead.
Jon Honeycutt
Comment 4 2015-07-27 14:10:05 PDT
Committed r187449: <http://trac.webkit.org/changeset/187449>
Note You need to log in before you can comment on or make changes to this bug.