Bug 147231 – Web Inspector: rewrite inspector-protocol/console tests to use new testing patterns

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Brian Burg]

These are currently poorly structured. This is also a simple test case for improving the way that tests listen for events (both with and without promises).

[Radar WebKit Bug Importer]

<rdar://problem/21966884>

[Brian Burg]

Created attachment 257362 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 257362 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257362&action=review

r=me

> LayoutTests/ChangeLog:29
> +        * inspector-protocol/console/console-message-expected.txt:
> +        * inspector-protocol/console/console-message.html:

I'd rather we just favor the LayoutTest/inspector/console tests, and remove these. But maybe I'll too idealistic.

> LayoutTests/http/tests/inspector-protocol/resources/InspectorTest.js:42
> +    if (typeof methodOrObject === "object") {
> +        var {method, params, handler} = methodOrObject;
> +    }

Style: braces

> LayoutTests/http/tests/inspector-protocol/resources/InspectorTest.js:91
> +    else if (typeof listeners == "function")

Style: ===

> LayoutTests/inspector-protocol/console/console-message-expected.txt:8
> +Running test case: ConsoleLogString

Would be nice to output newlines before running test cases to break the output up a bit and make it more readable.

[Brian Burg]

Comment on attachment 257362 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257362&action=review

>> LayoutTests/ChangeLog:29
>> +        * inspector-protocol/console/console-message.html:
> 
> I'd rather we just favor the LayoutTest/inspector/console tests, and remove these. But maybe I'll too idealistic.

I'm coming around to your point of view. However, there are some hardcoded path comparisons in DRT/WKTR that decide whether to use the stub or full frontend based on where the test lives. So this would be a separate patch.

>> LayoutTests/inspector-protocol/console/console-message-expected.txt:8
>> +Running test case: ConsoleLogString
> 
> Would be nice to output newlines before running test cases to break the output up a bit and make it more readable.

Agree, might as well make the change now before it spreads.

[Brian Burg]

Created attachment 257389 [details]
Patch for landing

[Joseph Pecoraro]

Comment on attachment 257389 [details]
Patch for landing

r=me

[WebKit Commit Bot]

Comment on attachment 257389 [details]
Patch for landing

Clearing flags on attachment: 257389

Committed r187269: <http://trac.webkit.org/changeset/187269>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.