These are currently poorly structured. This is also a simple test case for improving the way that tests listen for events (both with and without promises).
<rdar://problem/21966884>
Created attachment 257362 [details] Patch
Comment on attachment 257362 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257362&action=review r=me > LayoutTests/ChangeLog:29 > + * inspector-protocol/console/console-message-expected.txt: > + * inspector-protocol/console/console-message.html: I'd rather we just favor the LayoutTest/inspector/console tests, and remove these. But maybe I'll too idealistic. > LayoutTests/http/tests/inspector-protocol/resources/InspectorTest.js:42 > + if (typeof methodOrObject === "object") { > + var {method, params, handler} = methodOrObject; > + } Style: braces > LayoutTests/http/tests/inspector-protocol/resources/InspectorTest.js:91 > + else if (typeof listeners == "function") Style: === > LayoutTests/inspector-protocol/console/console-message-expected.txt:8 > +Running test case: ConsoleLogString Would be nice to output newlines before running test cases to break the output up a bit and make it more readable.
Comment on attachment 257362 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257362&action=review >> LayoutTests/ChangeLog:29 >> + * inspector-protocol/console/console-message.html: > > I'd rather we just favor the LayoutTest/inspector/console tests, and remove these. But maybe I'll too idealistic. I'm coming around to your point of view. However, there are some hardcoded path comparisons in DRT/WKTR that decide whether to use the stub or full frontend based on where the test lives. So this would be a separate patch. >> LayoutTests/inspector-protocol/console/console-message-expected.txt:8 >> +Running test case: ConsoleLogString > > Would be nice to output newlines before running test cases to break the output up a bit and make it more readable. Agree, might as well make the change now before it spreads.
Created attachment 257389 [details] Patch for landing
Comment on attachment 257389 [details] Patch for landing r=me
Comment on attachment 257389 [details] Patch for landing Clearing flags on attachment: 257389 Committed r187269: <http://trac.webkit.org/changeset/187269>
All reviewed patches have been landed. Closing bug.