Bug 147218 - Simplify DFG::DesiredIdentifiers and make it possible to turn a UniquedStringImpl* into an identifierNumber at any time
Summary: Simplify DFG::DesiredIdentifiers and make it possible to turn a UniquedString...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 146929
  Show dependency tree / graph
 
Reported: 2015-07-22 20:01 PDT by Filip Pizlo
Modified: 2015-07-22 22:00 PDT (History)
12 users (show)

See Also:

Attachments
the patch (8.07 KB, patch)
2015-07-22 20:07 PDT, Filip Pizlo 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-07-22 20:01:25 PDT 
In trunk, the DFG::ByteCodeParser can turn UniquedStringImpl*'s into identifierNumbers when it parses a new CodeBlock, but it cannot easily do it at any other time.  But it's trivial to just put that functionality inside DFG::DesiredIdentifiers, which will enable any phase (including ByteCodeParser) to turn a UniquedStringImpl* into an identifierNumber at any time.
Comment 1 Filip Pizlo 2015-07-22 20:07:22 PDT 
Created attachment 257331 [details]
the patch
Comment 2 Filip Pizlo 2015-07-22 22:00:19 PDT 
Landed in http://trac.webkit.org/changeset/187214