Bug 147200 - Introduce release assert for using threads before threading is initialized
Summary: Introduce release assert for using threads before threading is initialized
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-22 13:20 PDT by Filip Pizlo
Modified: 2015-07-22 13:50 PDT (History)
3 users (show)

See Also:

Attachments
the patch (1.48 KB, patch)
2015-07-22 13:24 PDT, Filip Pizlo 		msaboff: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-07-22 13:20:57 PDT 
Previously there was a debug assert in ThreadIdentifierData::identifier() that would catch this, but we can also have a release assert in initialize(), which is called much less frequently.
Comment 1 Filip Pizlo 2015-07-22 13:24:35 PDT 
Created attachment 257289 [details]
the patch
Comment 2 Michael Saboff 2015-07-22 13:41:59 PDT 
Comment on attachment 257289 [details]
the patch

r=me
Comment 3 Filip Pizlo 2015-07-22 13:50:57 PDT 
Landed in http://trac.webkit.org/changeset/187177