Bug 147197 - Use updated CoreAnimation snapshot SPI
Summary: Use updated CoreAnimation snapshot SPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 147213
Blocks:
  Show dependency tree / graph
 
Reported: 2015-07-22 11:42 PDT by James Savage
Modified: 2015-07-24 22:39 PDT (History)
6 users (show)

See Also:

Attachments
Updated SPI (5.10 KB, patch)
2015-07-22 11:51 PDT, James Savage 		thorton: review+
Details | Formatted Diff | Diff
Updated patch (5.09 KB, patch)
2015-07-22 17:40 PDT, James Savage 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Savage 2015-07-22 11:42:19 PDT 
Use new CoreAnimation SPI to address snapshotting unattached layer contexts.
Comment 1 James Savage 2015-07-22 11:51:09 PDT 
Created attachment 257283 [details]
Updated SPI
Comment 2 James Savage 2015-07-22 11:52:48 PDT 
<rdar://problem/21032083>
Comment 3 Tim Horton 2015-07-22 11:53:46 PDT 
Comment on attachment 257283 [details]
Updated SPI

View in context: https://bugs.webkit.org/attachment.cgi?id=257283&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:2893
> +        CARenderServerRenderDisplayLayerWithTransformAndTimeOffset(MACH_PORT_NULL, (__bridge CFStringRef)display.name, self.layer.context.contextId, reinterpret_cast<uint64_t>(self.layer), surface->surface(), 0, 0, &transform, 0);

Why the __bridge? This is not an ARC file.
Comment 4 James Savage 2015-07-22 17:40:37 PDT 
Created attachment 257314 [details]
Updated patch

Removed __bridge from typecast.
Comment 5 WebKit Commit Bot 2015-07-22 17:54:57 PDT 
Comment on attachment 257314 [details]
Updated patch

Clearing flags on attachment: 257314

Committed r187196: <http://trac.webkit.org/changeset/187196>
Comment 6 WebKit Commit Bot 2015-07-22 17:55:01 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Commit Bot 2015-07-22 18:16:55 PDT 
Re-opened since this is blocked by bug 147213
Comment 8 Tim Horton 2015-07-22 22:11:12 PDT 
Relanded in http://trac.webkit.org/changeset/187215
Comment 9 Tim Horton 2015-07-22 22:33:14 PDT 
http://trac.webkit.org/changeset/187216
Comment 10 Tim Horton 2015-07-23 01:00:02 PDT 
http://trac.webkit.org/changeset/187219
Comment 11 Ryosuke Niwa 2015-07-24 22:39:53 PDT 
iOS 8 build fix attempted in http://trac.webkit.org/changeset/187383.