Bug 147182 - Notify the UI delegate when a MediaDocument's natural size changes
Summary: Notify the UI delegate when a MediaDocument's natural size changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-21 19:18 PDT by Jer Noble
Modified: 2015-07-23 22:00 PDT (History)
1 user (show)

See Also:

Attachments
Patch (43.89 KB, patch)
2015-07-21 19:22 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (21.22 KB, patch)
2015-07-23 12:43 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (21.23 KB, patch)
2015-07-23 12:52 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (21.35 KB, patch)
2015-07-23 14:25 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (21.25 KB, patch)
2015-07-23 15:29 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (20.97 KB, patch)
2015-07-23 15:51 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (20.92 KB, patch)
2015-07-23 16:12 PDT, Jer Noble 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2015-07-21 19:18:45 PDT 
Notify the UI delegate when a MediaDocument's natural size changes
Comment 1 Jer Noble 2015-07-21 19:22:37 PDT 
Created attachment 257238 [details]
Patch
Comment 2 Jer Noble 2015-07-23 12:43:50 PDT 
Created attachment 257365 [details]
Patch
Comment 3 Jer Noble 2015-07-23 12:52:52 PDT 
Created attachment 257367 [details]
Patch
Comment 4 Jer Noble 2015-07-23 14:25:56 PDT 
Created attachment 257384 [details]
Patch
Comment 5 Jer Noble 2015-07-23 15:29:13 PDT 
Created attachment 257392 [details]
Patch
Comment 6 Jer Noble 2015-07-23 15:51:38 PDT 
Created attachment 257401 [details]
Patch
Comment 7 Jer Noble 2015-07-23 16:12:13 PDT 
Created attachment 257403 [details]
Patch
Comment 8 Simon Fraser (smfr) 2015-07-23 16:44:14 PDT 
Comment on attachment 257403 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257403&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:2119
> +            downcast<MediaDocument>(document()).mediaElementNaturalSizeChanged(expandedIntSize(m_player->naturalSize()));

We know that m_player is non-null?
Comment 9 Jer Noble 2015-07-23 16:46:05 PDT 
Comment on attachment 257403 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257403&action=review

>> Source/WebCore/html/HTMLMediaElement.cpp:2119
>> +            downcast<MediaDocument>(document()).mediaElementNaturalSizeChanged(expandedIntSize(m_player->naturalSize()));
> 
> We know that m_player is non-null?

This called from a callback made by the player, so it's guaranteed to be non-null.
Comment 10 Jer Noble 2015-07-23 16:48:35 PDT 
Committed r187272: <http://trac.webkit.org/changeset/187272>
Comment 11 Alex Christensen 2015-07-23 22:00:42 PDT 
Fixed 32-bit build in http://trac.webkit.org/changeset/187289