Bug 14717 - REGRESSION: 1% JavaScript performance regression fro Window refactoring
Summary: REGRESSION: 1% JavaScript performance regression fro Window refactoring
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 523.x (Safari 3)
Hardware: Macintosh OS X 10.4
: P1 Normal
Assignee: Maciej Stachowiak
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2007-07-22 19:32 PDT by Maciej Stachowiak
Modified: 2007-07-22 22:49 PDT (History)
0 users

See Also:


Attachments
the fix - inline some new methods (2.34 KB, patch)
2007-07-22 19:40 PDT, Maciej Stachowiak
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2007-07-22 19:32:45 PDT
Recent refactoring for the Window object's JS bindings has caused a 1% speed regression in JavaScript iBench and the "Celtic Kane" JavaScript speed test <http://celtickane.com/projects/jsspeed.php>. It shows up as 3% on the math test of that benchmark specifically. Inlining Window::impl() and DOMWindow::frame() fixes the regression.
Comment 1 Adam Roben (:aroben) 2007-07-22 19:37:03 PDT
<rdar://problem/5353174>
Comment 2 Maciej Stachowiak 2007-07-22 19:40:57 PDT
Created attachment 15639 [details]
the fix - inline some new methods
Comment 3 Adam Roben (:aroben) 2007-07-22 19:44:38 PDT
Comment on attachment 15639 [details]
the fix - inline some new methods

+        Frame* frame() { return m_frame; }

Seems like this should be a const method -- I wonder if anything depends on it not being one?

r=me
Comment 4 Maciej Stachowiak 2007-07-22 22:49:02 PDT
Fixed - I did not try to make any tweaks to const-correctness for now.