Bug 147141 - [Win] Add needTouchEvents() stub to WebChromeClient.h for a successful build with ENABLE_TOUCH_EVENTS=ON
Summary: [Win] Add needTouchEvents() stub to WebChromeClient.h for a successful build ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sungmann Cho
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-20 23:21 PDT by Sungmann Cho
Modified: 2015-07-21 16:16 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.33 KB, patch)
2015-07-20 23:25 PDT, Sungmann Cho 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sungmann Cho 2015-07-20 23:21:41 PDT 
Build ToT with ENABLE_TOUCH_EVENTS=ON on Windows breaks at:

WebView.cpp
..\..\win\WebView.cpp(2835): error C2259: 'WebChromeClient' : cannot instantiate abstract class
    due to following members:
    'void WebCore::ChromeClient::needTouchEvents(bool)' : is abstract
    D:\FOSS\WebKit\WebKitBuild\Debug_WinCairo\Include\WebCore/ChromeClient.h(371) : see declaration of 'WebCore::ChromeClient::needTouchEvents'

WebChromeClient needs needTouchEvents().
Comment 1 Sungmann Cho 2015-07-20 23:25:27 PDT 
Created attachment 257164 [details]
Patch
Comment 2 WebKit Commit Bot 2015-07-21 16:16:02 PDT 
Comment on attachment 257164 [details]
Patch

Clearing flags on attachment: 257164

Committed r187132: <http://trac.webkit.org/changeset/187132>
Comment 3 WebKit Commit Bot 2015-07-21 16:16:05 PDT 
All reviewed patches have been landed.  Closing bug.