WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
147141
[Win] Add needTouchEvents() stub to WebChromeClient.h for a successful build with ENABLE_TOUCH_EVENTS=ON
https://bugs.webkit.org/show_bug.cgi?id=147141
Summary
[Win] Add needTouchEvents() stub to WebChromeClient.h for a successful build ...
Sungmann Cho
Reported
2015-07-20 23:21:41 PDT
Build ToT with ENABLE_TOUCH_EVENTS=ON on Windows breaks at: WebView.cpp ..\..\win\WebView.cpp(2835): error C2259: 'WebChromeClient' : cannot instantiate abstract class due to following members: 'void WebCore::ChromeClient::needTouchEvents(bool)' : is abstract D:\FOSS\WebKit\WebKitBuild\Debug_WinCairo\Include\WebCore/ChromeClient.h(371) : see declaration of 'WebCore::ChromeClient::needTouchEvents' WebChromeClient needs needTouchEvents().
Attachments
Patch
(1.33 KB, patch)
2015-07-20 23:25 PDT
,
Sungmann Cho
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sungmann Cho
Comment 1
2015-07-20 23:25:27 PDT
Created
attachment 257164
[details]
Patch
WebKit Commit Bot
Comment 2
2015-07-21 16:16:02 PDT
Comment on
attachment 257164
[details]
Patch Clearing flags on attachment: 257164 Committed
r187132
: <
http://trac.webkit.org/changeset/187132
>
WebKit Commit Bot
Comment 3
2015-07-21 16:16:05 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug