Bug 147140 – DestructuringPatternNode and DestructuringAssignmentNode should be ParserArenaFreeable

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

And the descendants of DestructuringPatternNode that need destruction should be ParserArenaDeletable.

[Saam Barati]

Created attachment 257161 [details]
patch

[Build Bot]

Comment on attachment 257161 [details]
patch

Attachment 257161 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5043540103004160

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 257162 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 257161 [details]
patch

Attachment 257161 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5108245932802048

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 257165 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Saam Barati]

Created attachment 257167 [details]
patch

We want to make all Identifiers in the parser references to arena allocated Identifiers.
BindingPatterns were not doing this.

[Geoffrey Garen]

Comment on attachment 257167 [details]
patch

I think BindingNode needs to switch to const Identifier& as well.

[Saam Barati]

Comment on attachment 257167 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257167&action=review

> Source/JavaScriptCore/parser/Nodes.h:1826
> +        const Identifier& m_boundProperty;

This line is BindingNode switched to "const Identifier&"

[Geoffrey Garen]

Comment on attachment 257167 [details]
patch

Oops!

r=me

We should probably change the Identifier in ObjectPatternNode as well, just to match parsing conventions, even though it won't eliminate the destructor.

[WebKit Commit Bot]

Comment on attachment 257167 [details]
patch

Clearing flags on attachment: 257167

Committed r187111: <http://trac.webkit.org/changeset/187111>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.