RESOLVED FIXED 147139
API::Session should clean up its storage in the network process when destroyed.
https://bugs.webkit.org/show_bug.cgi?id=147139
Summary API::Session should clean up its storage in the network process when destroyed.
Andreas Kling
Reported 2015-07-20 19:54:03 PDT
Attachments
Proposed patch (1.65 KB, patch)
2015-07-20 20:02 PDT, Andreas Kling
no flags
Andreas Kling
Comment 1 2015-07-20 20:02:18 PDT
Created attachment 257157 [details] Proposed patch
Chris Dumez
Comment 2 2015-07-20 20:03:54 PDT
*** Bug 147138 has been marked as a duplicate of this bug. ***
Alexey Proskuryakov
Comment 3 2015-07-20 20:17:12 PDT
Comment on attachment 257157 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=257157&action=review > Source/WebKit2/ChangeLog:3 > + API::Session should clean up its storage in the network process when destroyed. Shouldn't it do the same for WebContent processes?
Andreas Kling
Comment 4 2015-07-20 20:27:52 PDT
Comment on attachment 257157 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=257157&action=review >> Source/WebKit2/ChangeLog:3 >> + API::Session should clean up its storage in the network process when destroyed. > > Shouldn't it do the same for WebContent processes? Hm, for the WebContent processes I only see calls that send: Messages::WebProcess::EnsurePrivateBrowsingSession(SessionID::legacyPrivateSessionID()) So they always use the same SessionID, never anything created by WKSessionCreate()
Alexey Proskuryakov
Comment 5 2015-07-20 20:39:08 PDT
Comment on attachment 257157 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=257157&action=review >>> Source/WebKit2/ChangeLog:3 >>> + API::Session should clean up its storage in the network process when destroyed. >> >> Shouldn't it do the same for WebContent processes? > > Hm, for the WebContent processes I only see calls that send: > > Messages::WebProcess::EnsurePrivateBrowsingSession(SessionID::legacyPrivateSessionID()) > > So they always use the same SessionID, never anything created by WKSessionCreate() It looks like WebContent processes get the session ID using WebPage::SetSessionID messages. I don't know why it's done differently for these processes now, would consult with Anders.
Anders Carlsson
Comment 6 2015-07-21 10:36:46 PDT
(In reply to comment #5) > Comment on attachment 257157 [details] > It looks like WebContent processes get the session ID using > WebPage::SetSessionID messages. I don't know why it's done differently for > these processes now, would consult with Anders. I think it's less important for the web processes since they have a much shorter lifespan (usually). Going forward, WKSessionRef should go away in favor of WebsiteDataStore, and it should be impossible to change sessions after the fact (since we haven't supported that feature since Mountain Lion).
Andreas Kling
Comment 7 2015-07-21 12:01:58 PDT
Comment on attachment 257157 [details] Proposed patch Thanks for the comment, Anders. cq+'ing.
WebKit Commit Bot
Comment 8 2015-07-21 12:55:42 PDT
Comment on attachment 257157 [details] Proposed patch Clearing flags on attachment: 257157 Committed r187115: <http://trac.webkit.org/changeset/187115>
WebKit Commit Bot
Comment 9 2015-07-21 12:55:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.