Bug 147130 - Web Inspector: console.assert(false, "Message") message is not visible in console
Summary: Web Inspector: console.assert(false, "Message") message is not visible in con...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-07-20 16:24 PDT by Joseph Pecoraro
Modified: 2015-09-01 15:12 PDT (History)
10 users (show)

See Also:

Attachments
[IMAGE] Before (36.77 KB, image/png)
2015-07-20 17:08 PDT, Joseph Pecoraro 		no flags Details
[IMAGE] After (43.51 KB, image/png)
2015-07-20 17:08 PDT, Joseph Pecoraro 		no flags Details
[PATCH] Proposed Fix (2.61 KB, patch)
2015-07-20 17:10 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-07-20 16:24:52 PDT 
* SUMMARY
console.assert(false, "Message") message is not visible in console

* STEPS TO REPRODUCE
1. js> console.assert(false, "Message", 1, 2)
  => only says "Assertion Failed:"

* NOTES
Looks like there is an Array.prototype.concat that doesn't get updated
Comment 1 Radar WebKit Bug Importer 2015-07-20 16:25:33 PDT 
<rdar://problem/21910109>
Comment 2 Joseph Pecoraro 2015-07-20 17:08:11 PDT 
Created attachment 257149 [details]
[IMAGE] Before
Comment 3 Joseph Pecoraro 2015-07-20 17:08:23 PDT 
Created attachment 257150 [details]
[IMAGE] After
Comment 4 Joseph Pecoraro 2015-07-20 17:10:25 PDT 
Created attachment 257151 [details]
[PATCH] Proposed Fix
Comment 5 WebKit Commit Bot 2015-07-20 17:59:57 PDT 
Comment on attachment 257151 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 257151

Committed r187052: <http://trac.webkit.org/changeset/187052>
Comment 6 WebKit Commit Bot 2015-07-20 18:00:01 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 David Kilzer (:ddkilzer) 2015-09-01 14:53:34 PDT 
Is this issue testable?
Comment 8 Alexey Proskuryakov 2015-09-01 14:53:57 PDT 
Comment on attachment 257151 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=257151&action=review

> Source/WebInspectorUI/ChangeLog:4
> +        Web Inspector: console.assert(false, "Message") message is not visible in console
> +        https://bugs.webkit.org/show_bug.cgi?id=147130

THERE ARE NO TESTS!
Comment 9 Timothy Hatcher 2015-09-01 15:12:36 PDT 
We don't have UI tests in the Web Inspector. This was a change in the View object. We only test the Model and Controller objects.