Bug 147126 – Remove revealing getVideoTracks() and getAudioTracks()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Matthew Daiter]

We need to remove these methods in order to not have to reveal anything we shouldn't be revealing.

[Radar WebKit Bug Importer]

<rdar://problem/21908723>

[Matthew Daiter]

Created attachment 257132 [details]
Patch

[Eric Carlson]

Comment on attachment 257132 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257132&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:140
> +        m_MediaStreamPrivate->addTrack(&*track, MediaStreamPrivate::NotifyClientOption::DontNotify);

&*track is strange. If the compiler requires "&*", can you get rid of it by explicitly declaring "type"'s track instead of using auto?

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:174
>          return MediaPlayerPrivateInterface::platformLayer();

MediaPlayerPrivateInterface::platformLayer returns 0, why don't you just return nullptr here instead of calling it.

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:175
> +    return (PlatformLayer*)m_previewLayer;

You should use a C++ style cast here.

[Matthew Daiter]

Comment on attachment 257132 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257132&action=review

>> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:140
>> +        m_MediaStreamPrivate->addTrack(&*track, MediaStreamPrivate::NotifyClientOption::DontNotify);
> 
> &*track is strange. If the compiler requires "&*", can you get rid of it by explicitly declaring "type"'s track instead of using auto?

Better way of doing this: std::move()

>> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:174
>>          return MediaPlayerPrivateInterface::platformLayer();
> 
> MediaPlayerPrivateInterface::platformLayer returns 0, why don't you just return nullptr here instead of calling it.

Just wanted to call this for clarity. I can return a nullptr here.

>> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:175
>> +    return (PlatformLayer*)m_previewLayer;
> 
> You should use a C++ style cast here.

Sure. static_cast<> it is.

[Matthew Daiter]

Created attachment 257200 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 257200 [details]
Patch

Clearing flags on attachment: 257200

Committed r187164: <http://trac.webkit.org/changeset/187164>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.