Bug 147115 - Fix the !ENABLE(DETAILS_ELEMENT) build after r186598
Summary: Fix the !ENABLE(DETAILS_ELEMENT) build after r186598
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 146549
  Show dependency tree / graph
 
Reported: 2015-07-20 11:41 PDT by Csaba Osztrogonác
Modified: 2015-07-21 12:23 PDT (History)
10 users (show)

See Also:

Attachments
Patch (1.51 KB, patch)
2015-07-20 11:43 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-07-20 11:41:53 PDT 
http://trac.webkit.org/changeset/186598 broke the !ENABLE(DETAILS_ELEMENT) build:

lib/libwebcore_efl.a(lib/../Source/WebCore/CMakeFiles/WebCore.dir/accessibility/AccessibilityNodeObject.cpp.o):AccessibilityNodeObject.cpp:function WebCore::AccessibilityNodeObject::setIsExpanded(bool): error: undefined reference to 'WebCore::HTMLDetailsElement::toggleOpen()'
collect2: error: ld returned 1 exit status

The problem is that WebCore::HTMLDetailsElement::toggleOpen() is defined inside
ENABLE(DETAILS_ELEMENT), but used unconditionally in AccessibilityNodeObject.cpp.
Comment 1 Csaba Osztrogonác 2015-07-20 11:43:27 PDT 
Created attachment 257111 [details]
Patch
Comment 2 Csaba Osztrogonác 2015-07-21 11:05:41 PDT 
ping?
Comment 3 WebKit Commit Bot 2015-07-21 12:23:17 PDT 
Comment on attachment 257111 [details]
Patch

Clearing flags on attachment: 257111

Committed r187112: <http://trac.webkit.org/changeset/187112>
Comment 4 WebKit Commit Bot 2015-07-21 12:23:21 PDT 
All reviewed patches have been landed.  Closing bug.