Bug 147104 - Remove RenderTheme::shouldShowPlaceholderWhenFocused()
Summary: Remove RenderTheme::shouldShowPlaceholderWhenFocused()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2015-07-20 02:57 PDT by Carlos Garcia Campos
Modified: 2015-07-20 22:35 PDT (History)
4 users (show)

See Also:


Attachments
Patch (6.94 KB, patch)
2015-07-20 02:59 PDT, Carlos Garcia Campos
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2015-07-20 02:57:04 PDT
GTK+ is the only port that returns false in shouldShowPlaceholderWhenFocused(). That's inconsistent with all other browsers that show the placeholder text even for focused entries in all platforms. We should change the GTK+ port behaviour, but that would leave all implementations of shouldShowPlaceholderWhenFocused returning true, so let's just remove it.
Comment 1 Carlos Garcia Campos 2015-07-20 02:59:43 PDT
Created attachment 257084 [details]
Patch

This makes the GTK+ port consistent with all other browsers, but inconsistent with GTK+ itself, I'll write a patch for GTK+.
Comment 2 Carlos Garcia Campos 2015-07-20 03:07:39 PDT
See https://bugzilla.gnome.org/show_bug.cgi?id=752622
Comment 3 Carlos Garcia Campos 2015-07-20 22:35:18 PDT
Committed r187095: <http://trac.webkit.org/changeset/187095>