Bug 147091 - Media Session: test 'Transient Solo' interruptions
Summary: Media Session: test 'Transient Solo' interruptions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 145411
  Show dependency treegraph
 
Reported: 2015-07-19 11:22 PDT by Matt Rajca
Modified: 2015-07-29 12:56 PDT (History)
4 users (show)

See Also:


Attachments
Patch (5.36 KB, patch)
2015-07-19 11:24 PDT, Matt Rajca
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Rajca 2015-07-19 11:22:15 PDT
'Transient Solo' interruptions should pause/unpause active media elements.
Comment 1 Radar WebKit Bug Importer 2015-07-19 11:22:44 PDT
<rdar://problem/21892120>
Comment 2 Matt Rajca 2015-07-19 11:24:47 PDT
Created attachment 257064 [details]
Patch
Comment 3 Eric Carlson 2015-07-27 09:23:08 PDT
Comment on attachment 257064 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257064&action=review

> LayoutTests/media/session/transient-solo-interruptions.html:14
> +            if (window.testRunner) {
> +                testRunner.dumpAsText();
> +                testRunner.waitUntilDone();
> +            }

Nit: this isn't necessary because you include video-test.js.

> LayoutTests/media/session/transient-solo-interruptions.html:16
> +            window.jsTestIsAsync = true;

Nit: this is unnecessary, it isn't used by the video testing harness.

> LayoutTests/media/session/transient-solo-interruptions.html:30
> +            document.getElementById("video").play();

Nit: there is only one <video> so you can just use "video" instead of searching for the element.

> LayoutTests/media/session/transient-solo-interruptions.html:35
> +            document.getElementById("video").onplaying = null;

Ditto.
Comment 4 Matt Rajca 2015-07-29 12:53:12 PDT
(In reply to comment #3)
> Comment on attachment 257064 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=257064&action=review
> 
> > LayoutTests/media/session/transient-solo-interruptions.html:14
> > +            if (window.testRunner) {
> > +                testRunner.dumpAsText();
> > +                testRunner.waitUntilDone();
> > +            }
> 
> Nit: this isn't necessary because you include video-test.js.

Removed.

> 
> > LayoutTests/media/session/transient-solo-interruptions.html:16
> > +            window.jsTestIsAsync = true;
> 
> Nit: this is unnecessary, it isn't used by the video testing harness.

Removed.

> 
> > LayoutTests/media/session/transient-solo-interruptions.html:30
> > +            document.getElementById("video").play();
> 
> Nit: there is only one <video> so you can just use "video" instead of
> searching for the element.

Changed.

> 
> > LayoutTests/media/session/transient-solo-interruptions.html:35
> > +            document.getElementById("video").onplaying = null;
> 
> Ditto.
Comment 5 Matt Rajca 2015-07-29 12:56:52 PDT
Committed r187552: <http://trac.webkit.org/changeset/187552>