Bug 147091 – Media Session: test 'Transient Solo' interruptions

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Matt Rajca]

'Transient Solo' interruptions should pause/unpause active media elements.

[Radar WebKit Bug Importer]

<rdar://problem/21892120>

[Matt Rajca]

Created attachment 257064 [details]
Patch

[Eric Carlson]

Comment on attachment 257064 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257064&action=review

> LayoutTests/media/session/transient-solo-interruptions.html:14
> +            if (window.testRunner) {
> +                testRunner.dumpAsText();
> +                testRunner.waitUntilDone();
> +            }

Nit: this isn't necessary because you include video-test.js.

> LayoutTests/media/session/transient-solo-interruptions.html:16
> +            window.jsTestIsAsync = true;

Nit: this is unnecessary, it isn't used by the video testing harness.

> LayoutTests/media/session/transient-solo-interruptions.html:30
> +            document.getElementById("video").play();

Nit: there is only one <video> so you can just use "video" instead of searching for the element.

> LayoutTests/media/session/transient-solo-interruptions.html:35
> +            document.getElementById("video").onplaying = null;

Ditto.

[Matt Rajca]

(In reply to comment #3)
> Comment on attachment 257064 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=257064&action=review
> 
> > LayoutTests/media/session/transient-solo-interruptions.html:14
> > +            if (window.testRunner) {
> > +                testRunner.dumpAsText();
> > +                testRunner.waitUntilDone();
> > +            }
> 
> Nit: this isn't necessary because you include video-test.js.

Removed.

> 
> > LayoutTests/media/session/transient-solo-interruptions.html:16
> > +            window.jsTestIsAsync = true;
> 
> Nit: this is unnecessary, it isn't used by the video testing harness.

Removed.

> 
> > LayoutTests/media/session/transient-solo-interruptions.html:30
> > +            document.getElementById("video").play();
> 
> Nit: there is only one <video> so you can just use "video" instead of
> searching for the element.

Changed.

> 
> > LayoutTests/media/session/transient-solo-interruptions.html:35
> > +            document.getElementById("video").onplaying = null;
> 
> Ditto.

[Matt Rajca]

Committed r187552: <http://trac.webkit.org/changeset/187552>