Bug 147080 - Media Session: add infrastructure for testing ducking
Summary: Media Session: add infrastructure for testing ducking
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 145411
  Show dependency tree / graph
 
Reported: 2015-07-18 21:52 PDT by Matt Rajca
Modified: 2015-07-23 15:04 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.19 KB, patch)
2015-07-18 21:57 PDT, Matt Rajca 		no flags Details | Formatted Diff | Diff
Patch (3.88 KB, patch)
2015-07-19 09:35 PDT, Matt Rajca 		no flags Details | Formatted Diff | Diff
Patch (4.26 KB, patch)
2015-07-23 14:46 PDT, Matt Rajca 		jer.noble: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Rajca 2015-07-18 21:52:49 PDT 
We need a way of getting a media element's underlying media player's volume (which will be lowered when audio is ducked).
Comment 1 Radar WebKit Bug Importer 2015-07-18 21:53:17 PDT 
<rdar://problem/21890395>
Comment 2 Matt Rajca 2015-07-18 21:57:31 PDT 
Created attachment 257052 [details]
Patch
Comment 3 Matt Rajca 2015-07-19 09:35:17 PDT 
Created attachment 257058 [details]
Patch
Comment 4 Matt Rajca 2015-07-23 14:46:33 PDT 
Created attachment 257387 [details]
Patch
Comment 5 Jer Noble 2015-07-23 14:58:13 PDT 
Comment on attachment 257387 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257387&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:6486
> +    if (m_player)
> +        return m_player->volume();
> +    return 0;

This could be more concisely stated as:

return m_player ? m_player->volume() : 0;
Comment 6 Matt Rajca 2015-07-23 15:03:35 PDT 
(In reply to comment #5)
> Comment on attachment 257387 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=257387&action=review
> 
> > Source/WebCore/html/HTMLMediaElement.cpp:6486
> > +    if (m_player)
> > +        return m_player->volume();
> > +    return 0;
> 
> This could be more concisely stated as:
> 
> return m_player ? m_player->volume() : 0;

Fixed.
Comment 7 Matt Rajca 2015-07-23 15:04:01 PDT 
Committed r187256: <http://trac.webkit.org/changeset/187256>