Bug 147058 - [iOS] TextIndicator has a large forehead when line-height > 1
Summary: [iOS] TextIndicator has a large forehead when line-height > 1
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-17 16:51 PDT by Tim Horton
Modified: 2015-07-17 17:22 PDT (History)
4 users (show)

See Also:

Attachments
Patch (7.24 KB, patch)
2015-07-17 16:53 PDT, Tim Horton 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-07-17 16:51:43 PDT 
[iOS] TextIndicator has a large forehead when line-height > 1
Comment 1 Tim Horton 2015-07-17 16:53:34 PDT 
Created attachment 257004 [details]
Patch
Comment 2 Dean Jackson 2015-07-17 17:09:00 PDT 
Comment on attachment 257004 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257004&action=review

> Source/WebKit2/ChangeLog:11
> +        Apply a review comment that I left myself and then forgot about.

Huh? A review comment from another fix?
Comment 3 Tim Horton 2015-07-17 17:20:50 PDT 
(In reply to comment #2)
> Comment on attachment 257004 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=257004&action=review
> 
> > Source/WebKit2/ChangeLog:11
> > +        Apply a review comment that I left myself and then forgot about.
> 
> Huh? A review comment from another fix?

Yes. But still related to this! (and the original version of this patch actually depended on that review comment having been applied, so I've just kept it around).
Comment 4 Tim Horton 2015-07-17 17:22:32 PDT 
http://trac.webkit.org/changeset/186978