Bug 147045 - Video posters disappear once media has loaded
Summary: Video posters disappear once media has loaded
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-07-17 13:22 PDT by Myles C. Maxfield
Modified: 2015-07-17 16:02 PDT (History)
8 users (show)

See Also:

Attachments
Patch (3.85 KB, patch)
2015-07-17 13:26 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (4.32 KB, patch)
2015-07-17 14:37 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (4.39 KB, patch)
2015-07-17 15:16 PDT, Myles C. Maxfield 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-07-17 13:22:40 PDT 
Video posters disappear once media has loaded
Comment 1 Myles C. Maxfield 2015-07-17 13:26:04 PDT 
Created attachment 256982 [details]
Patch
Comment 2 Myles C. Maxfield 2015-07-17 13:32:41 PDT 
<rdar://problem/21359811>
Comment 3 Simon Fraser (smfr) 2015-07-17 13:37:24 PDT 
Comment on attachment 256982 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256982&action=review

r+ on the code change, but the test needs tweaking.

> LayoutTests/compositing/video/poster.html:13
> +<p>This test makes sure that video posters are displayed even after the source is loaded</p>
> +<video id="v" src="../resources/video.mp4" poster="../resources/simple_image.png"></video>

Doesn't this bug only reproduce if controls are shown, or the video is composited for other reasons?

You should use the scripts used by media tests to load the video, too.
Comment 4 Eric Carlson 2015-07-17 13:55:24 PDT 
Comment on attachment 256982 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256982&action=review

>> LayoutTests/compositing/video/poster.html:13
>> +<video id="v" src="../resources/video.mp4" poster="../resources/simple_image.png"></video>
> 
> Doesn't this bug only reproduce if controls are shown, or the video is composited for other reasons?
> 
> You should use the scripts used by media tests to load the video, too.

Yes, please include media-file.js and use findMediaFile.
Comment 5 Myles C. Maxfield 2015-07-17 14:37:42 PDT 
Created attachment 256990 [details]
Patch
Comment 6 Myles C. Maxfield 2015-07-17 15:16:15 PDT 
Created attachment 256997 [details]
Patch
Comment 7 Myles C. Maxfield 2015-07-17 16:02:25 PDT 
Committed r186968: <http://trac.webkit.org/changeset/186968>