Bug 147042 – Media Session: Add support for 'Content' interruption types

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Matt Rajca]

When a start-of-interruption notification comes in with a 'Content' interruption type, all media elements should be paused indefinitely.

[Radar WebKit Bug Importer]

<rdar://problem/21876104>

[Matt Rajca]

Created attachment 256976 [details]
Patch

[Eric Carlson]

(In reply to comment #2)
> Created attachment 256976 [details]
> Patch

Please include a test with this change.

[Matt Rajca]

Created attachment 257009 [details]
Patch

[Matt Rajca]

(In reply to comment #3)
> (In reply to comment #2)
> > Created attachment 256976 [details]
> > Patch
> 
> Please include a test with this change.

Added. It depends on Bug 147060.

[Eric Carlson]

Comment on attachment 257009 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257009&action=review

> LayoutTests/media/session/content-interruptions.html:52
> +    <video id="video" src="../content/counting.mp4" />

Please include media-file.js and use src=findMediaFile("../content/counting") so this will work on platforms that don't support MPEG-4.

[Build Bot]

Comment on attachment 257009 [details]
Patch

Attachment 257009 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4621183756533760

New failing tests:
media/session/content-interruptions.html

[Build Bot]

Created attachment 257022 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 257009 [details]
Patch

Attachment 257009 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6226449258250240

New failing tests:
media/session/content-interruptions.html

[Build Bot]

Created attachment 257023 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Matt Rajca]

(In reply to comment #6)
> Comment on attachment 257009 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=257009&action=review
> 
> > LayoutTests/media/session/content-interruptions.html:52
> > +    <video id="video" src="../content/counting.mp4" />
> 
> Please include media-file.js and use
> src=findMediaFile("../content/counting") so this will work on platforms that
> don't support MPEG-4.

Fixed.

[Matt Rajca]

(In reply to comment #7)
> Comment on attachment 257009 [details]
> Patch
> 
> Attachment 257009 [details] did not pass mac-ews (mac):
> Output: http://webkit-queues.appspot.com/results/4621183756533760
> 
> New failing tests:
> media/session/content-interruptions.html

Forgot to update TestExpectations.

[Matt Rajca]

Committed r187006: <http://trac.webkit.org/changeset/187006>