Bug 147037 - Improve rect shrink-wrapping algorithm
Summary: Improve rect shrink-wrapping algorithm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-17 05:17 PDT by Tim Horton
Modified: 2015-07-17 16:58 PDT (History)
5 users (show)

See Also:

Attachments
Patch (124.82 KB, patch)
2015-07-17 05:20 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (135.02 KB, patch)
2015-07-17 14:57 PDT, Tim Horton 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-07-17 05:17:37 PDT 
Improve rect shrink-wrapping algorithm
Comment 1 Tim Horton 2015-07-17 05:20:31 PDT 
Created attachment 256967 [details]
Patch
Comment 2 Tim Horton 2015-07-17 05:21:39 PDT 
This is probably best read as a side-by-side diff or something because it's basically a rewrite of the whole file and the unified diff is completely useless.
Comment 3 Tim Horton 2015-07-17 14:57:09 PDT 
Created attachment 256993 [details]
Patch
Comment 4 WebKit Commit Bot 2015-07-17 14:59:11 PDT 
Attachment 256993 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/PathUtilities.cpp:270:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Simon Fraser (smfr) 2015-07-17 16:28:20 PDT 
Comment on attachment 256993 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256993&action=review

> Source/WebCore/platform/graphics/PathUtilities.cpp:42
> +    class Node : public FloatPoint {

I think this should be a "has a" FloatPoint, not "Is a" FloatPoint
Comment 6 Tim Horton 2015-07-17 16:58:49 PDT 
http://trac.webkit.org/changeset/186976