RESOLVED FIXED147037
Improve rect shrink-wrapping algorithm 
https://bugs.webkit.org/show_bug.cgi?id=147037
Summary Improve rect shrink-wrapping algorithm
Tim Horton
Reported 2015-07-17 05:17:37 PDT
Improve rect shrink-wrapping algorithm
Attachments
Patch (124.82 KB, patch)
2015-07-17 05:20 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (135.02 KB, patch)
2015-07-17 14:57 PDT, Tim Horton 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2015-07-17 05:20:31 PDT
Created attachment 256967 [details] Patch
Tim Horton
Comment 2 2015-07-17 05:21:39 PDT
This is probably best read as a side-by-side diff or something because it's basically a rewrite of the whole file and the unified diff is completely useless.
Tim Horton
Comment 3 2015-07-17 14:57:09 PDT
Created attachment 256993 [details] Patch
WebKit Commit Bot
Comment 4 2015-07-17 14:59:11 PDT
Attachment 256993 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/PathUtilities.cpp:270: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 5 2015-07-17 16:28:20 PDT
Comment on attachment 256993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256993&action=review > Source/WebCore/platform/graphics/PathUtilities.cpp:42 > + class Node : public FloatPoint { I think this should be a "has a" FloatPoint, not "Is a" FloatPoint
Tim Horton
Comment 6 2015-07-17 16:58:49 PDT
http://trac.webkit.org/changeset/186976
Note You need to log in before you can comment on or make changes to this bug.