Bug 147035 - [GTK] Cleanup PasteboardHelper
Summary: [GTK] Cleanup PasteboardHelper
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on:
Reported: 2015-07-17 00:59 PDT by Carlos Garcia Campos
Modified: 2015-07-17 02:24 PDT (History)
6 users (show)

See Also:

Patch (17.59 KB, patch)
2015-07-17 01:06 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Updated patch (17.74 KB, patch)
2015-07-17 02:07 PDT, Carlos Garcia Campos
zan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2015-07-17 00:59:18 PDT
It's actually a singleton, but the API suggests you can create your own or use the default one, but the default one should be the only one.
Comment 1 Carlos Garcia Campos 2015-07-17 01:06:22 PDT
Created attachment 256960 [details]
Comment 2 WebKit Commit Bot 2015-07-17 01:08:35 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Zan Dobersek 2015-07-17 01:51:14 PDT
Comment on attachment 256960 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=256960&action=review

> Source/WebCore/ChangeLog:11
> +        PasteboardHelper::singleton() and make it non-copiable, fast

Nit: non-copyable.

> Source/WebCore/platform/gtk/PasteboardHelper.cpp:70
> +    gMarkupPrefix = String::fromUTF8("<meta http-equiv=\"content-type\" content=\"text/html; charset=utf-8\">");

Not terribly important since it's only called once, but this string seems ASCII-only, so you could initialize gMarkipPrefix from an ASCIILiteral.

Also, can this be initialized where it's declared?

> Source/WebCore/platform/gtk/PasteboardHelper.h:38

No need for WTF_MAKE_FAST_ALLOCATED. There's only one object alive during the program's lifetime, and that one is constructed in memory that's reserved by the static NeverDestroyed<PasteboardHelper> object.
Comment 4 Carlos Garcia Campos 2015-07-17 02:07:08 PDT
Created attachment 256962 [details]
Updated patch
Comment 5 Carlos Garcia Campos 2015-07-17 02:24:51 PDT
Committed r186954: <http://trac.webkit.org/changeset/186954>