Bug 147035 – [GTK] Cleanup PasteboardHelper

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Carlos Garcia Campos]

It's actually a singleton, but the API suggests you can create your own or use the default one, but the default one should be the only one.

[Carlos Garcia Campos]

Created attachment 256960 [details]
Patch

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Zan Dobersek]

Comment on attachment 256960 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256960&action=review

> Source/WebCore/ChangeLog:11
> +        PasteboardHelper::singleton() and make it non-copiable, fast

Nit: non-copyable.

> Source/WebCore/platform/gtk/PasteboardHelper.cpp:70
> +    gMarkupPrefix = String::fromUTF8("<meta http-equiv=\"content-type\" content=\"text/html; charset=utf-8\">");

Not terribly important since it's only called once, but this string seems ASCII-only, so you could initialize gMarkipPrefix from an ASCIILiteral.

Also, can this be initialized where it's declared?

> Source/WebCore/platform/gtk/PasteboardHelper.h:38
> +    WTF_MAKE_NONCOPYABLE(PasteboardHelper); WTF_MAKE_FAST_ALLOCATED;

No need for WTF_MAKE_FAST_ALLOCATED. There's only one object alive during the program's lifetime, and that one is constructed in memory that's reserved by the static NeverDestroyed<PasteboardHelper> object.

[Carlos Garcia Campos]

Created attachment 256962 [details]
Updated patch

[Carlos Garcia Campos]

Committed r186954: <http://trac.webkit.org/changeset/186954>