Bug 147030 - Remove DFG::DesiredWriteBarriers because it's just a very difficult way of saying "please barrier the machine code block owner"
Summary: Remove DFG::DesiredWriteBarriers because it's just a very difficult way of sa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 146929
  Show dependency treegraph
 
Reported: 2015-07-16 20:01 PDT by Filip Pizlo
Modified: 2015-07-17 22:51 PDT (History)
12 users (show)

See Also:


Attachments
the patch (20.66 KB, patch)
2015-07-16 20:03 PDT, Filip Pizlo
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-07-16 20:01:16 PDT
Just doing:

vm.heap.writeBarrier(codeBlock->ownerExecutable()

somewhere in Plan is equivalent to all of what DesiredWriteBarriers amounts to, since:

- All of the uses of it pass codeBlock->ownerExecutable() as the owner.
- It's guaranteed that a barrier on the owner executable will be executed as a result of compilation, so we might as well just do it unconditionally.
Comment 1 Filip Pizlo 2015-07-16 20:03:59 PDT
Created attachment 256954 [details]
the patch
Comment 2 Andreas Kling 2015-07-17 13:52:50 PDT
Comment on attachment 256954 [details]
the patch

r=me
Comment 3 Filip Pizlo 2015-07-17 22:51:05 PDT
Landed in http://trac.webkit.org/changeset/186985