Bug 147015 - WebsiteDataStore operations need to grab background assertions
Summary: WebsiteDataStore operations need to grab background assertions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-16 14:12 PDT by Anders Carlsson
Modified: 2015-07-20 10:10 PDT (History)
1 user (show)

See Also:


Attachments
Patch (5.21 KB, patch)
2015-07-16 14:12 PDT, Anders Carlsson
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-07-16 14:12:13 PDT
WebsiteDataStore operations need to grab background assertions
Comment 1 Anders Carlsson 2015-07-16 14:12:43 PDT
Created attachment 256924 [details]
Patch
Comment 2 mitz 2015-07-16 14:34:23 PDT
Comment on attachment 256924 [details]
Patch

We normally have the callers create the callbacks using the create function that takes an activity token. That’s why we added that parameter. Can you follow that established pattern in this case?
Comment 3 mitz 2015-07-16 14:39:25 PDT
(In reply to comment #2)
> Comment on attachment 256924 [details]
> Patch
> 
> We normally have the callers create the callbacks using the create function
> that takes an activity token. That’s why we added that parameter. Can you
> follow that established pattern in this case?

I forgot to mention that we normally do this using CallbackMap.
Comment 4 Anders Carlsson 2015-07-17 10:34:20 PDT
(In reply to comment #3)
> (In reply to comment #2)
> > Comment on attachment 256924 [details]
> > Patch
> > 
> > We normally have the callers create the callbacks using the create function
> > that takes an activity token. That’s why we added that parameter. Can you
> > follow that established pattern in this case?
> 
> I forgot to mention that we normally do this using CallbackMap.

I'm not going to make such an invasive change at this point.
Comment 5 Sam Weinig 2015-07-17 14:06:35 PDT
Comment on attachment 256924 [details]
Patch

Seems worth adding FIXMEs about using CallbackMap in the future.
Comment 6 Anders Carlsson 2015-07-20 10:09:28 PDT
Committed r187023: <http://trac.webkit.org/changeset/187023>
Comment 7 Anders Carlsson 2015-07-20 10:10:49 PDT
(In reply to comment #5)
> Comment on attachment 256924 [details]
> Patch
> 
> Seems worth adding FIXMEs about using CallbackMap in the future.

The ability to do async messages with replies should be built into IPC::Connection, not layered on top of it.