RESOLVED FIXED146992
Move indicator rect uniting code to TextIndicatorWindow instead of TextIndicator 
https://bugs.webkit.org/show_bug.cgi?id=146992
Summary Move indicator rect uniting code to TextIndicatorWindow instead of TextIndicator
Tim Horton
Reported 2015-07-15 18:08:19 PDT
Move indicator rect uniting code to TextIndicatorWindow instead of TextIndicator
Attachments
Patch (6.31 KB, patch)
2015-07-15 18:09 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2015-07-15 18:09:05 PDT
Created attachment 256882 [details] Patch
Daniel Bates
Comment 2 2015-07-15 22:43:02 PDT
Comment on attachment 256882 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256882&action=review > Source/WebCore/page/TextIndicator.cpp:-52 > -const float dropShadowBlurRadius = 12; Notice that the !ENABLE(LEGACY_TEXT_INDICATOR_STYLE)-variant of the constant dropShadowBlurRadius is defined to be 2 (not 12 as it is defined here) in file Source/WebCore/page/mac/TextIndicatorWindow.mm, <http://trac.webkit.org/browser/trunk/Source/WebCore/page/mac/TextIndicatorWindow.mm?rev=185844#L60>. Is this change in blur radius intentional?
Tim Horton
Comment 3 2015-07-15 22:49:52 PDT
Must be a mistake I made long ago (this is why having two copies of the constants is bad!). In any case, the version in TextIndicatorWindow is the "real" one (the one that actually determines... the size of the shadow); this one was just here for this silly rect merging code. Thanks for your very careful review!
WebKit Commit Bot
Comment 4 2015-07-15 23:38:06 PDT
Comment on attachment 256882 [details] Patch Clearing flags on attachment: 256882 Committed r186890: <http://trac.webkit.org/changeset/186890>
WebKit Commit Bot
Comment 5 2015-07-15 23:38:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.