Bug 146992 - Move indicator rect uniting code to TextIndicatorWindow instead of TextIndicator
Summary: Move indicator rect uniting code to TextIndicatorWindow instead of TextIndicator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-15 18:08 PDT by Tim Horton
Modified: 2015-07-15 23:38 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.31 KB, patch)
2015-07-15 18:09 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-07-15 18:08:19 PDT 
Move indicator rect uniting code to TextIndicatorWindow instead of TextIndicator
Comment 1 Tim Horton 2015-07-15 18:09:05 PDT 
Created attachment 256882 [details]
Patch
Comment 2 Daniel Bates 2015-07-15 22:43:02 PDT 
Comment on attachment 256882 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256882&action=review

> Source/WebCore/page/TextIndicator.cpp:-52
> -const float dropShadowBlurRadius = 12;

Notice that the !ENABLE(LEGACY_TEXT_INDICATOR_STYLE)-variant of the constant dropShadowBlurRadius is defined to be 2 (not 12 as it is defined here) in file Source/WebCore/page/mac/TextIndicatorWindow.mm, <http://trac.webkit.org/browser/trunk/Source/WebCore/page/mac/TextIndicatorWindow.mm?rev=185844#L60>. Is this change in blur radius intentional?
Comment 3 Tim Horton 2015-07-15 22:49:52 PDT 
Must be a mistake I made long ago (this is why having two copies of the constants is bad!). In any case, the version in TextIndicatorWindow is the "real" one (the one that actually determines... the size of the shadow); this one was just here for this silly rect merging code. Thanks for your very careful review!
Comment 4 WebKit Commit Bot 2015-07-15 23:38:06 PDT 
Comment on attachment 256882 [details]
Patch

Clearing flags on attachment: 256882

Committed r186890: <http://trac.webkit.org/changeset/186890>
Comment 5 WebKit Commit Bot 2015-07-15 23:38:10 PDT 
All reviewed patches have been landed.  Closing bug.