Bug 146991 - Web Inspector: [Mac] Save dialog not working when inspector is docked
Summary: Web Inspector: [Mac] Save dialog not working when inspector is docked
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-07-15 17:55 PDT by Joseph Pecoraro
Modified: 2015-07-16 17:30 PDT (History)
12 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (6.07 KB, patch)
2015-07-15 18:31 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-07-15 17:55:26 PDT
* SUMMARY
[Mac] Save dialog not working when trying to save from text editor

* STEPS TO REPRODUCE
1. Inspect a local test page with scripts
2. Dock inspector
3. Select a script
4. Modify the script
5. Hit ⌘S to present save dialog
6. Save in the dialog
  => save panel does not dismiss

* NOTES
- NSSavePanel/NSOpenPanel handlers expect non-null window argument, hanging is when they are given a null argument.
Comment 1 Joseph Pecoraro 2015-07-15 17:55:36 PDT
<rdar://problem/21834578>
Comment 2 Joseph Pecoraro 2015-07-15 18:31:46 PDT
Created attachment 256885 [details]
[PATCH] Proposed Fix
Comment 3 WebKit Commit Bot 2015-07-15 18:33:04 PDT
Attachment 256885 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm:350:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm:713:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:237:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:625:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 4 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Brian Burg 2015-07-16 09:28:22 PDT
Comment on attachment 256885 [details]
[PATCH] Proposed Fix

LGTM, would like Tim to take a peek though.
Comment 5 Joseph Pecoraro 2015-07-16 11:26:35 PDT
Will need at least a nod from a WK2 Owner.
Comment 6 WebKit Commit Bot 2015-07-16 17:30:18 PDT
Comment on attachment 256885 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 256885

Committed r186919: <http://trac.webkit.org/changeset/186919>
Comment 7 WebKit Commit Bot 2015-07-16 17:30:22 PDT
All reviewed patches have been landed.  Closing bug.