* SUMMARY [Mac] Save dialog not working when trying to save from text editor * STEPS TO REPRODUCE 1. Inspect a local test page with scripts 2. Dock inspector 3. Select a script 4. Modify the script 5. Hit ⌘S to present save dialog 6. Save in the dialog => save panel does not dismiss * NOTES - NSSavePanel/NSOpenPanel handlers expect non-null window argument, hanging is when they are given a null argument.
<rdar://problem/21834578>
Created attachment 256885 [details] [PATCH] Proposed Fix
Attachment 256885 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm:350: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm:713: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:237: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:625: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 4 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 256885 [details] [PATCH] Proposed Fix LGTM, would like Tim to take a peek though.
Will need at least a nod from a WK2 Owner.
Comment on attachment 256885 [details] [PATCH] Proposed Fix Clearing flags on attachment: 256885 Committed r186919: <http://trac.webkit.org/changeset/186919>
All reviewed patches have been landed. Closing bug.