Bug 146973 – Factor rect shrink-wrapping code out of RenderThemeMac for future reuse

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

Factor rect shrink-wrapping code out of RenderThemeMac for future reuse

[Tim Horton]

Created attachment 256855 [details]
Patch

[WebKit Commit Bot]

Attachment 256855 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/PathUtilities.cpp:172:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebCore/platform/graphics/PathUtilities.cpp:214:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 2 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anders Carlsson]

Comment on attachment 256855 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256855&action=review

> Source/WebCore/html/canvas/DOMPath.cpp:35
> +

No newline.

> Source/WebCore/platform/graphics/PathUtilities.cpp:205
> +    Vector<FloatRect> soloRects = rects;

WTF::move.

[Tim Horton]

Comment on attachment 256855 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256855&action=review

>> Source/WebCore/platform/graphics/PathUtilities.cpp:205
>> +    Vector<FloatRect> soloRects = rects;
> 
> WTF::move.

I don't think so? Making a copy to remove all the non-solo rects from while we run through the vector below.

[Tim Horton]

http://trac.webkit.org/changeset/186858

[Mark Lam]

Looks like this broke the Windows build.  See https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/71566.

c:\cygwin\home\buildbot\slave\win-release\build\source\webcore\html\canvas\DOMPath.h(41): error C2487: '{dtor}' : member of dll interface class may not be declared with dll interface (..\html\canvas\CanvasRenderingContext2D.cpp) [C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\WebCore.vcxproj\WebCore.vcxproj]

[Tim Horton]

(In reply to comment #6)
> Looks like this broke the Windows build.  See
> https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/
> 71566.
> 
> c:\cygwin\home\buildbot\slave\win-
> release\build\source\webcore\html\canvas\DOMPath.h(41): error C2487:
> '{dtor}' : member of dll interface class may not be declared with dll
> interface (..\html\canvas\CanvasRenderingContext2D.cpp)
> [C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\WebCore.
> vcxproj\WebCore.vcxproj]

Didn't bfulgham fix this in http://trac.webkit.org/changeset/186875?

[Mark Lam]

(In reply to comment #7)
> Didn't bfulgham fix this in http://trac.webkit.org/changeset/186875?

You are correct.  The present build failure is due to something else.  Sorry for the noise.