Bug 146973 - Factor rect shrink-wrapping code out of RenderThemeMac for future reuse
Summary: Factor rect shrink-wrapping code out of RenderThemeMac for future reuse
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-15 13:35 PDT by Tim Horton
Modified: 2015-07-16 01:08 PDT (History)
6 users (show)

See Also:

Attachments
Patch (76.84 KB, patch)
2015-07-15 13:36 PDT, Tim Horton 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-07-15 13:35:37 PDT 
Factor rect shrink-wrapping code out of RenderThemeMac for future reuse
Comment 1 Tim Horton 2015-07-15 13:36:43 PDT 
Created attachment 256855 [details]
Patch
Comment 2 WebKit Commit Bot 2015-07-15 13:38:21 PDT 
Attachment 256855 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/PathUtilities.cpp:172:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebCore/platform/graphics/PathUtilities.cpp:214:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 2 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2015-07-15 13:40:38 PDT 
Comment on attachment 256855 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256855&action=review

> Source/WebCore/html/canvas/DOMPath.cpp:35
> +

No newline.

> Source/WebCore/platform/graphics/PathUtilities.cpp:205
> +    Vector<FloatRect> soloRects = rects;

WTF::move.
Comment 4 Tim Horton 2015-07-15 13:44:58 PDT 
Comment on attachment 256855 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256855&action=review

>> Source/WebCore/platform/graphics/PathUtilities.cpp:205
>> +    Vector<FloatRect> soloRects = rects;
> 
> WTF::move.

I don't think so? Making a copy to remove all the non-solo rects from while we run through the vector below.
Comment 5 Tim Horton 2015-07-15 14:20:55 PDT 
http://trac.webkit.org/changeset/186858
Comment 6 Mark Lam 2015-07-16 00:43:03 PDT 
Looks like this broke the Windows build.  See https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/71566.

c:\cygwin\home\buildbot\slave\win-release\build\source\webcore\html\canvas\DOMPath.h(41): error C2487: '{dtor}' : member of dll interface class may not be declared with dll interface (..\html\canvas\CanvasRenderingContext2D.cpp) [C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\WebCore.vcxproj\WebCore.vcxproj]
Comment 7 Tim Horton 2015-07-16 01:04:00 PDT 
(In reply to comment #6)
> Looks like this broke the Windows build.  See
> https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/
> 71566.
> 
> c:\cygwin\home\buildbot\slave\win-
> release\build\source\webcore\html\canvas\DOMPath.h(41): error C2487:
> '{dtor}' : member of dll interface class may not be declared with dll
> interface (..\html\canvas\CanvasRenderingContext2D.cpp)
> [C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\WebCore.
> vcxproj\WebCore.vcxproj]

Didn't bfulgham fix this in http://trac.webkit.org/changeset/186875?
Comment 8 Mark Lam 2015-07-16 01:08:36 PDT 
(In reply to comment #7)
> Didn't bfulgham fix this in http://trac.webkit.org/changeset/186875?

You are correct.  The present build failure is due to something else.  Sorry for the noise.