WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
146967
jsc-tailcall: Only non-constructors functions are candidate for tail calls
https://bugs.webkit.org/show_bug.cgi?id=146967
Summary
jsc-tailcall: Only non-constructors functions are candidate for tail calls
Basile Clement
Reported
2015-07-15 10:18:29 PDT
We were emitting tail calls at the Program / Script level (which is weird but probably inconsequential) and in ES6 constructors (which is completely wrong and semantics-breaking). Patch forthcoming.
Attachments
Patch
(3.26 KB, patch)
2015-07-15 10:29 PDT
,
Basile Clement
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Basile Clement
Comment 1
2015-07-15 10:29:51 PDT
Created
attachment 256845
[details]
Patch
Saam Barati
Comment 2
2015-07-15 10:37:18 PDT
Comment on
attachment 256845
[details]
Patch Looks good to me.
Basile Clement
Comment 3
2015-07-15 10:43:41 PDT
Committed
r186848
<
http://trac.webkit.org/changeset/186848
> on branch jsc-tailcall.
Csaba Osztrogonác
Comment 4
2015-09-14 10:57:04 PDT
Comment on
attachment 256845
[details]
Patch Cleared review? from
attachment 256845
[details]
so that this bug does not appear in
http://webkit.org/pending-review
. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug