Bug 146960 – [EFL] Implements the button of the scrollbar.

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebKit EFL

[Hunseop Jeong]

Added the button of the scrollbar and remove the unnecessary color property in edc.

[Hunseop Jeong]

Created attachment 256826 [details]
Patch

[Ryuan Choi]

Comment on attachment 256826 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256826&action=review

> Source/WebCore/platform/efl/ScrollbarThemeEfl.cpp:46
> +static const int buttonLength = 10;

Can we have different value of buttonLength from thickness?

[Gyuyoung Kim]

Comment on attachment 256826 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256826&action=review

> Source/WebCore/ChangeLog:21
> +          calculate the size of button and paint the button.`

Remove ` at the end of line.

> Source/WebCore/platform/efl/DefaultTheme/widget/scrollbar/scrollbar.edc:115
> +                   * If wants to draw on top, just overflow using edje's rel1/rel2

Wrong indentation.

> Source/WebCore/platform/efl/DefaultTheme/widget/scrollbar/scrollbar.edc:165
> +                    * If wants to draw on top, just overflow using edje's rel1/rel2

ditto.

> Source/WebCore/platform/efl/ScrollbarThemeEfl.cpp:128
> +    if (part == BackButtonStartPart)

In this case, switch ~ case looks better.

[Hunseop Jeong]

Created attachment 256964 [details]
Patch

[Hunseop Jeong]

(In reply to comment #2)
> Comment on attachment 256826 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=256826&action=review
> 
> > Source/WebCore/platform/efl/ScrollbarThemeEfl.cpp:46
> > +static const int buttonLength = 10;
> 
> Can we have different value of buttonLength from thickness?

Should we have the same value?

[Hunseop Jeong]

Created attachment 256965 [details]
Patch

[Hunseop Jeong]

Created attachment 256966 [details]
Patch

[Hunseop Jeong]

(In reply to comment #3)
> Comment on attachment 256826 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=256826&action=review
> 
> > Source/WebCore/ChangeLog:21
> > +          calculate the size of button and paint the button.`
> 
> Remove ` at the end of line.
> 
> > Source/WebCore/platform/efl/DefaultTheme/widget/scrollbar/scrollbar.edc:115
> > +                   * If wants to draw on top, just overflow using edje's rel1/rel2
> 
> Wrong indentation.
> 
> > Source/WebCore/platform/efl/DefaultTheme/widget/scrollbar/scrollbar.edc:165
> > +                    * If wants to draw on top, just overflow using edje's rel1/rel2
> 
> ditto.
> 
> > Source/WebCore/platform/efl/ScrollbarThemeEfl.cpp:128
> > +    if (part == BackButtonStartPart)
> 
> In this case, switch ~ case looks better.

Done. I will be more careful about the small mistakes :(

[Alex Christensen]

Comment on attachment 256966 [details]
Patch

EFL port was removed.  This patch is no longer needed in trunk.

[Michael Catanzaro]

Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.