Bug 146952 - Analysis tasks that start at the very first data point doesn't load
Summary: Analysis tasks that start at the very first data point doesn't load
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-14 17:12 PDT by Ryosuke Niwa
Modified: 2015-10-09 03:29 PDT (History)
4 users (show)

See Also:

Attachments
Fixes the bug (1.90 KB, patch)
2015-07-14 17:18 PDT, Ryosuke Niwa 		dbates: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-07-14 17:12:57 PDT 
JavaScript blows up :(
Comment 1 Ryosuke Niwa 2015-07-14 17:18:36 PDT 
Created attachment 256812 [details]
Fixes the bug
Comment 2 Daniel Bates 2015-07-15 22:30:32 PDT 
Comment on attachment 256812 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=256812&action=review

> Websites/perf.webkit.org/public/v2/data.js:534
> +    if (!('seriesIndex' in endPoint))

This is not correct. Notice that the existing logic prevented indexing into this._series with a negative index.

> Websites/perf.webkit.org/public/v2/data.js:541
> +    if (!('seriesIndex' in endPoint))

I take it you meant to write "point" instead of "endPoint" in the expression for this if-statement.
Comment 3 Daniel Bates 2015-07-15 22:32:39 PDT 
(In reply to comment #2)
> Comment on attachment 256812 [details]
> Fixes the bug
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=256812&action=review
> 
> > Websites/perf.webkit.org/public/v2/data.js:534
> > +    if (!('seriesIndex' in endPoint))
> 
> [...] Notice that the existing logic prevented indexing into
> this._series with a negative index.

I meant to write:

Notice that the existing logic prevented indexing into this._series with a negative index when point.seriesIndex == 0.
Comment 4 Ryosuke Niwa 2015-10-09 03:29:34 PDT 
This patch is obsolete now.